Make OrderRecalculatorPatch prepend explicit#6376
Merged
adammathys merged 1 commit intosolidusio:mainfrom Nov 25, 2025
Merged
Conversation
Prepending a configurable class runs into all kinds of trouble with load order. If the patch is loaded before the configuration changes, the newly configured class won't have the patch applied. This shows up fairly often in tests, but could also be an issue in other environments if the config is not set to run before all of the code is eager loaded. Co-authored-by: Jared Norman <jared@super.gd> Co-authored-by: Noah Silvera <noah@super.gd> Co-Authored-By: Sofia Besenski <sofia@super.gd> Co-Authored-By: Chris Todorov <chris@super.gd> Co-Authored-By: Alistair Norman <alistair@super.gd>
github-actions
bot
added
the
changelog:solidus_promotions
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6376 +/- ##
==========================================
+ Coverage 89.37% 89.45% +0.07%
==========================================
Files 961 974 +13
Lines 20200 20322 +122
==========================================
+ Hits 18054 18179 +125
+ Misses 2146 2143 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mamhoff
approved these changes
Nov 20, 2025
5 tasks
adammathys
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepending a configurable class runs into all kinds of trouble with load order. If the patch is loaded before the configuration changes, the newly configured class won't have the patch applied.
This shows up fairly often in tests, but could also be an issue in other environments if the config is not set to run before all of the code is eager loaded.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: