Skip to content

Improve order updater test coverage #6377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adammathys merged 7 commits into from
Nov 25, 2025
+285 −197
Merged

Improve order updater test coverage #6377

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c82f731
Add describe block to Shipment#update_amounts test
Noah-Silvera Oct 25, 2024
2f0d626
Add missing Promotions::OrderAdjuster spec
Noah-Silvera Feb 14, 2025
e206b24
Refactored shipment recalculation tests
benjaminwil Sep 11, 2025
a7973de
Update classic order updater specs
sofiabesenski4 Oct 9, 2025
8f3b465
Make test assertion independent of config
forkata Oct 16, 2025
3dce4db
Remove describe block for private method
AlistairNorman Nov 20, 2025
db98d00
Test that changes to item totals are respected
AlistairNorman Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion promotions/spec/lib/solidus_promotions/engine_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,15 @@

RSpec.describe SolidusPromotions::Engine do
describe "initializer.flickwerk_alias" do
around do |example|
original_value = Spree::Config.order_recalculator_class_name
Spree::Config.order_recalculator_class = "ThisIsATestClassName"

example.run

Spree::Config.order_recalculator_class = original_value
end

it "sets the Flickwerk alias for order_recalculator_class" do
Flickwerk.aliases["Spree::Config.order_recalculator_class"] = nil

Expand All @@ -12,7 +21,7 @@

initializer = SolidusPromotions::Engine.initializers.find { |i| i.name == "solidus_promotions.flickwerk_alias" }
initializer.run
expect(Flickwerk.aliases["Spree::Config.order_recalculator_class"]).to eq("Spree::OrderUpdater")
expect(Flickwerk.aliases["Spree::Config.order_recalculator_class"]).to eq("ThisIsATestClassName")
Copy link
Contributor

@mamhoff mamhoff Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With #6376, we probably don't need the Flickwerk alias to be there anymore. Not blocking, just a note that the feature can be removed.

end
end
end