[v4.6] Fix line item option condition params #6396
Merged
+91
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the product picker for the line_item_option_value form to not allow selecting multiple products per entry. (cherry picked from commit 36b8821)
This fixes an issue where the option-value-picker was not receiving the id for the selected product. Therefore the correct option values where not available and the params where malformed. (cherry picked from commit 8947ff5) # Conflicts: # promotions/spec/system/solidus_promotions/backend/promotions_spec.rb
When creating an option value condition, we only want to have option values that fit the product in question. This commit makes it such that the option value picker re-initializes when the selected product changes. (cherry picked from commit b45afe7)
mamhoff
added
backport-v4.5
4 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4.6 #6396 +/- ##
=======================================
Coverage 89.36% 89.36%
=======================================
Files 963 963
Lines 20213 20213
=======================================
Hits 18064 18064
Misses 2149 2149 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
(cherry picked from commit b0eda8b)
mamhoff
force-pushed
the
backport/v4.6/pr-6233
branch
from
0e67c62 to
4109116
Compare
tvdeyen
approved these changes
Dec 5, 2025
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintov4.6:Questions ?
Please refer to the Backport tool documentation