-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Add reusable workflow for extension testing #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7b0e443 to
a700c89
Compare
tvdeyen
added a commit
to tvdeyen/solidus_auth_devise
that referenced
this pull request
Jan 4, 2026
Instead of setting up all services and the matrix in this extension we use the new reusable workflow that handles this for us. Needs solidusio/test-solidus-extension#3
tvdeyen
added a commit
to tvdeyen/solidus_auth_devise
that referenced
this pull request
Jan 4, 2026
Instead of setting up all services and the matrix in this extension we use the new reusable workflow that handles this for us. Needs solidusio/test-solidus-extension#3
5 tasks
Member
Author
|
Testing with solidusio/solidus_auth_devise#269 |
5 tasks
a700c89 to
7bf4a27
Compare
tvdeyen
added a commit
to solidusio/solidus_auth_devise
that referenced
this pull request
Jan 4, 2026
Instead of setting up all services and the matrix in this extension we use the new reusable workflow that handles this for us. Needs solidusio/test-solidus-extension#3
7bf4a27 to
bb6a20a
Compare
tvdeyen
added a commit
to solidusio/solidus_auth_devise
that referenced
this pull request
Jan 4, 2026
Instead of setting up all services and the matrix in this extension we use the new reusable workflow that handles this for us. Needs solidusio/test-solidus-extension#3
tvdeyen
added a commit
to solidusio/solidus_auth_devise
that referenced
this pull request
Jan 4, 2026
Instead of setting up all services and the matrix in this extension we use the new reusable workflow that handles this for us. Needs solidusio/test-solidus-extension#3
bb6a20a to
e9a78d9
Compare
tvdeyen
added a commit
to solidusio/solidus_auth_devise
that referenced
this pull request
Jan 4, 2026
Instead of setting up all services and the matrix in this extension we use the new reusable workflow that handles this for us. Needs solidusio/test-solidus-extension#3
e9a78d9 to
de3c366
Compare
tvdeyen
added a commit
to solidusio/solidus_auth_devise
that referenced
this pull request
Jan 4, 2026
Instead of setting up all services and the matrix in this extension we use the new reusable workflow that handles this for us. Needs solidusio/test-solidus-extension#3
3af5634 to
52641e4
Compare
Add a reusable workflow that handles database services (PostgreSQL, MySQL) so extensions don't need to define them manually. The workflow accepts individual inputs for rails_versions, ruby_versions, solidus_branches, and databases with sensible defaults. This provides a simpler alternative to the composite action while maintaining backwards compatibility.
52641e4 to
0b9198a
Compare
This is fixed in Rails 8.0.1
tvdeyen
added a commit
to solidusio/solidus_auth_devise
that referenced
this pull request
Jan 5, 2026
Instead of setting up all services and the matrix in this extension we use the new reusable workflow that handles this for us. Needs solidusio/test-solidus-extension#3
mamhoff
approved these changes
Jan 5, 2026
tvdeyen
added a commit
to solidusio/solidus_auth_devise
that referenced
this pull request
Jan 5, 2026
Instead of setting up all services and the matrix in this extension we use the new reusable workflow that handles this for us. Needs solidusio/test-solidus-extension#3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a reusable workflow that handles database services (PostgreSQL, MySQL)
so extensions don't need to define them manually. The workflow accepts
individual inputs for
rails_versions,ruby_versions,solidus_branches,and
databaseswith sensible defaults.This provides a simpler alternative to the composite action while
maintaining backwards compatibility.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: