Skip to content

Conversation

@tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jan 4, 2026

Summary

Add a reusable workflow that handles database services (PostgreSQL, MySQL)
so extensions don't need to define them manually. The workflow accepts
individual inputs for rails_versions, ruby_versions, solidus_branches,
and databases with sensible defaults.

This provides a simpler alternative to the composite action while
maintaining backwards compatibility.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@tvdeyen tvdeyen force-pushed the add-reusable-workflow branch 2 times, most recently from 7b0e443 to a700c89 Compare January 4, 2026 20:37
tvdeyen added a commit to tvdeyen/solidus_auth_devise that referenced this pull request Jan 4, 2026
Instead of setting up all services and the matrix
in this extension we use the new reusable workflow
that handles this for us.

Needs solidusio/test-solidus-extension#3
tvdeyen added a commit to tvdeyen/solidus_auth_devise that referenced this pull request Jan 4, 2026
Instead of setting up all services and the matrix
in this extension we use the new reusable workflow
that handles this for us.

Needs solidusio/test-solidus-extension#3
@tvdeyen
Copy link
Member Author

tvdeyen commented Jan 4, 2026

Testing with solidusio/solidus_auth_devise#269

@tvdeyen tvdeyen marked this pull request as ready for review January 4, 2026 20:44
@tvdeyen tvdeyen force-pushed the add-reusable-workflow branch from a700c89 to 7bf4a27 Compare January 4, 2026 20:54
tvdeyen added a commit to solidusio/solidus_auth_devise that referenced this pull request Jan 4, 2026
Instead of setting up all services and the matrix
in this extension we use the new reusable workflow
that handles this for us.

Needs solidusio/test-solidus-extension#3
@tvdeyen tvdeyen force-pushed the add-reusable-workflow branch from 7bf4a27 to bb6a20a Compare January 4, 2026 20:56
tvdeyen added a commit to solidusio/solidus_auth_devise that referenced this pull request Jan 4, 2026
Instead of setting up all services and the matrix
in this extension we use the new reusable workflow
that handles this for us.

Needs solidusio/test-solidus-extension#3
tvdeyen added a commit to solidusio/solidus_auth_devise that referenced this pull request Jan 4, 2026
Instead of setting up all services and the matrix
in this extension we use the new reusable workflow
that handles this for us.

Needs solidusio/test-solidus-extension#3
@tvdeyen tvdeyen force-pushed the add-reusable-workflow branch from bb6a20a to e9a78d9 Compare January 4, 2026 21:05
tvdeyen added a commit to solidusio/solidus_auth_devise that referenced this pull request Jan 4, 2026
Instead of setting up all services and the matrix
in this extension we use the new reusable workflow
that handles this for us.

Needs solidusio/test-solidus-extension#3
@tvdeyen tvdeyen force-pushed the add-reusable-workflow branch from e9a78d9 to de3c366 Compare January 4, 2026 21:08
tvdeyen added a commit to solidusio/solidus_auth_devise that referenced this pull request Jan 4, 2026
Instead of setting up all services and the matrix
in this extension we use the new reusable workflow
that handles this for us.

Needs solidusio/test-solidus-extension#3
@tvdeyen tvdeyen requested a review from a team January 4, 2026 21:11
@tvdeyen tvdeyen force-pushed the add-reusable-workflow branch from 3af5634 to 52641e4 Compare January 4, 2026 21:26
Add a reusable workflow that handles database services (PostgreSQL, MySQL)
so extensions don't need to define them manually. The workflow accepts
individual inputs for rails_versions, ruby_versions, solidus_branches,
and databases with sensible defaults.

This provides a simpler alternative to the composite action while
maintaining backwards compatibility.
@tvdeyen tvdeyen force-pushed the add-reusable-workflow branch from 52641e4 to 0b9198a Compare January 5, 2026 09:31
This is fixed in Rails 8.0.1
tvdeyen added a commit to solidusio/solidus_auth_devise that referenced this pull request Jan 5, 2026
Instead of setting up all services and the matrix
in this extension we use the new reusable workflow
that handles this for us.

Needs solidusio/test-solidus-extension#3
@tvdeyen tvdeyen merged commit 11043ff into main Jan 5, 2026
1 check passed
tvdeyen added a commit to solidusio/solidus_auth_devise that referenced this pull request Jan 5, 2026
Instead of setting up all services and the matrix
in this extension we use the new reusable workflow
that handles this for us.

Needs solidusio/test-solidus-extension#3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants