Add example issues. #1

mwz · 2019-12-20T23:03:06Z

No description provided.

sonar-scala-bot · 2019-12-20T23:23:30Z

module1/src/main/scala/Example1.scala

@@ -1,3 +1,8 @@
 object Example1 {
  def sum(a: Int, b: Int) = a + b


Public method must have type (more)

sonar-scala-bot · 2019-12-20T23:23:32Z

module1/src/main/scala/Example1.scala

 object Example1 {
  def sum(a: Int, b: Int) = a + b
+
+  def ExampleIssues: Unit = {


Parameterless methods returns unit (more)

sonar-scala-bot · 2019-12-20T23:23:33Z

module1/src/main/scala/Example1.scala

 object Example1 {
  def sum(a: Int, b: Int) = a + b
+
+  def ExampleIssues: Unit = {


Method name not recommended (more)

sonar-scala-bot · 2019-12-20T23:23:34Z

module1/src/main/scala/Example1.scala

 object Example1 {
  def sum(a: Int, b: Int) = a + b
+
+  def ExampleIssues: Unit = {


Method name (more)

sonar-scala-bot · 2019-12-20T23:23:35Z

module1/src/main/scala/Example1.scala

  def sum(a: Int, b: Int) = a + b
+
+  def ExampleIssues: Unit = {
+    val isEmpty = List(1).size == 0


List.size is O(n) (more)

sonar-scala-bot · 2019-12-20T23:23:36Z

module1/src/main/scala/Example1.scala

  def sum(a: Int, b: Int) = a + b
+
+  def ExampleIssues: Unit = {
+    val isEmpty = List(1).size == 0


Avoid Traversable.size == 0 (more)

sonar-scala-bot · 2019-12-20T23:23:37Z

module1/src/main/scala/Example1.scala

  def sum(a: Int, b: Int) = a + b
+
+  def ExampleIssues: Unit = {
+    val isEmpty = List(1).size == 0


Literal passed as argument without name (more)

sonar-scala-bot · 2019-12-20T23:23:38Z

module1/src/main/scala/Example1.scala

+
+  def ExampleIssues: Unit = {
+    val isEmpty = List(1).size == 0
+    ???


Usage of ??? operator (more)

sonar-scala-bot · 2019-12-20T23:23:39Z

module2/src/main/scala/Example2.scala

@@ -1,3 +1,8 @@
 object Example2 {
  def sum(a: Int, b: Int) = a + b


Public method must have type (more)

sonar-scala-bot · 2019-12-20T23:23:40Z

module2/src/main/scala/Example2.scala

 object Example2 {
  def sum(a: Int, b: Int) = a + b
+
+  def ExampleIssues: Unit = {


Parameterless methods returns unit (more)

sonar-scala-bot · 2019-12-20T23:23:41Z

module2/src/main/scala/Example2.scala

 object Example2 {
  def sum(a: Int, b: Int) = a + b
+
+  def ExampleIssues: Unit = {


Method name not recommended (more)

sonar-scala-bot · 2019-12-20T23:23:42Z

module2/src/main/scala/Example2.scala

 object Example2 {
  def sum(a: Int, b: Int) = a + b
+
+  def ExampleIssues: Unit = {


Method name (more)

sonar-scala-bot · 2019-12-20T23:23:43Z

module2/src/main/scala/Example2.scala

  def sum(a: Int, b: Int) = a + b
+
+  def ExampleIssues: Unit = {
+    val a = (14 / 1).toInt


Unnecessary toInt (more)

sonar-scala-bot · 2019-12-20T23:23:44Z

module2/src/main/scala/Example2.scala

+
+  def ExampleIssues: Unit = {
+    val a = (14 / 1).toInt
+    return ()


Return (more)

Add example issues.

890bd83

sonar-scala-bot reviewed Dec 20, 2019

View reviewed changes

module2/src/main/scala/Example2.scala

def ExampleIssues: Unit = {

val a = (14 / 1).toInt

return ()

Copy link

Collaborator

sonar-scala-bot Dec 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return (more)

		@@ -1,3 +1,8 @@
		object Example1 {
		def sum(a: Int, b: Int) = a + b

		@@ -1,3 +1,8 @@
		object Example2 {
		def sum(a: Int, b: Int) = a + b

Add example issues. #1

Are you sure you want to change the base?

Add example issues. #1

Uh oh!

Conversation

mwz commented Dec 20, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants