fix: don't call s3 reference while s3.async is used#2513
Open
treehousedevelopers wants to merge 1 commit intosonata-project:4.xfrom
Open
fix: don't call s3 reference while s3.async is used#2513treehousedevelopers wants to merge 1 commit intosonata-project:4.xfrom
treehousedevelopers wants to merge 1 commit intosonata-project:4.xfrom
Conversation
Author
|
I think, it duplicates : #2490, I missed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, to fix configuration issue while S3 is used with async client. In this case there is no reference
sonata.media.adapter.service.s3and should not be called in configuration.Changelog
fix: don't call s3 reference while s3.async is used