Skip to content

Conversation

eerison
Copy link
Contributor

@eerison eerison commented May 27, 2025

Clean up installation doc

I am targeting this branch, because it does not have any break change and can be introduce on version 4.x.

Changelog

### Changed
- Simplify installation doc

I was playing with sonata pagebundle in a new symfony project and I was strugulling to make this work 😄 ,
after a while I realised the issue was, because new symfony projects are using php attributes as default, for this reason I am changing the recipes: symfony/recipes-contrib#1809

and running composer require sonata-project/page-bundle -W it works as expected.

here there is some screenshots

Screenshot from 2025-05-27 20-18-32

Screenshot from 2025-05-27 20-24-40

@eerison eerison force-pushed the clean-up-install-doc branch from 7c773c9 to f02e60d Compare May 27, 2025 18:27
@eerison eerison marked this pull request as ready for review May 27, 2025 18:29
Copy link
Member

@VincentLanglet VincentLanglet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot assume that people are using flex (and recipes).
That's why the doc is descriptive.

So you shouldn't remove part that are automatically added by flex/recipe ; and keep consistency with other packages doc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants