Skip to content

RoleMatrix: allow without AdminBundle#1733

Merged
VincentLanglet merged 9 commits intosonata-project:5.xfrom
Hanmac:withoutAdmin
Dec 15, 2025
Merged

RoleMatrix: allow without AdminBundle#1733
VincentLanglet merged 9 commits intosonata-project:5.xfrom
Hanmac:withoutAdmin

Conversation

@Hanmac
Copy link
Contributor

@Hanmac Hanmac commented Dec 10, 2025

Subject

I am targeting this branch, because it should be BC.

Closes #1731.

Changelog

### Changed
- makes references to `service('sonata.admin.pool')` and `service('sonata.admin.configuration')` optional.
- makes references to `service('sonata.user.admin_roles_builder')` and `service('sonata.user.security_roles_builder')` optional.

@Hanmac
Copy link
Contributor Author

Hanmac commented Dec 10, 2025

hmm the null checks are kinda stupid, the functions aren't even called when the pool or configuration is null

@Hanmac
Copy link
Contributor Author

Hanmac commented Dec 15, 2025

@VincentLanglet this MR should be ready?
The Psalm problem is unrelated
and the i can't get the pending tests to run

@VincentLanglet
Copy link
Member

@VincentLanglet this MR should be ready? The Psalm problem is unrelated and the i can't get the pending tests to run

Yes, we're kinda stuck until #1728 is merged ; @dmaicher is working on it.

@dmaicher
Copy link
Contributor

@VincentLanglet this MR should be ready? The Psalm problem is unrelated and the i can't get the pending tests to run

Yes, we're kinda stuck until #1728 is merged ; @dmaicher is working on it.

yeah I was hoping this could all be done quicker but we are still blocked by external dependencies. This will be fixed in #1730 with adding Symfony 8 compatibility

@dmaicher
Copy link
Contributor

dmaicher commented Dec 15, 2025

@Hanmac CI was fixed in #1734 just now, Can you rebase?

Only the Symfony 8 job should fail which you can ignore

@dmaicher
Copy link
Contributor

@BadPixxel can you confirm this fixes #1731 for you?

@BadPixxel
Copy link

Hi, Many thx for all your efforts! it pass on my side! You can close #1731.

@Hanmac
Copy link
Contributor Author

Hanmac commented Dec 15, 2025

@dmaicher I was thinking about reviving #1519 but that might be for another day 😅

@VincentLanglet VincentLanglet merged commit 2bff96f into sonata-project:5.x Dec 15, 2025
23 of 24 checks passed
@Hanmac Hanmac deleted the withoutAdmin branch December 16, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using User Bundle without Admin -> Unknown "renderMatrix" function

4 participants