[DASH] Move route rule table priority to key #2091
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lawrence Lee <[email protected]>
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the DASH Route Rule Table schema to move the priority field from an attribute to part of the table key. This change affects the inbound routing rule configuration by incorporating priority directly into the key structure rather than as a separate field.
- Moved
priorityfrom a table attribute to part of the composite key inDASH_ROUTE_RULE_TABLE - Deprecated the
priorityattribute field while maintaining backward compatibility documentation - Updated schema documentation and examples to reflect the new key structure
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SAI DASH inbound routing header has the routing entry priority as part of the entry key. To prevent having multiple DASH_ROUTE_RULE_TABLE entries with the same priority, deprecate the priority field and store the priority in the key to match the SAI definition.