Passing -M option to orchange to enable SAI MACSec POST #24492
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- FIPS is enabled in SONiC; AND - MACSec is enabled on platform.
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
Contributor
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
judyjoseph
reviewed
Nov 18, 2025
| # - FIPS is enabled in SONiC (either in /proc/cmdline or /etc/fips/fips_enable); AND | ||
| # - MACSec is enabled on platform. | ||
| if grep -q "sonic_fips=1" /proc/cmdline || grep -q "1" /etc/fips/fips_enable ; then | ||
| if grep -q "macsec_enabled=1" /usr/share/sonic/platform/platform_env.conf 2>/dev/null ; then |
Contributor
There was a problem hiding this comment.
Can we use source platform_env.conf or something line this https://github.com/criteo-forks/sonic-buildimage/blob/a9caf1152e1ed3d91cf7adf390dd89dfeb8602c5/files/scripts/asic_status.sh#L5
Contributor
Author
There was a problem hiding this comment.
Hi @judyjoseph update review to source platform_env.conf as suggested.
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing -M option to orchange to enable SAI MACSec POST when:
Why I did it
sonic-net/sonic-swss#3836 adds
-Moption to orchagent to enable SAI MACSec POST. This PR passes the option to orchagent when:Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)