Skip to content

Passing -M option to orchange to enable SAI MACSec POST #24492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+11 −0
Open

Passing -M option to orchange to enable SAI MACSec POST #24492

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0913ae3
Passing -M option to orchange to enable SAI MACSec POST when:
ysmanman Nov 11, 2025
7fce051
source platform_env.conf to check if macsec is enabled on platform or…
ysmanman Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions dockers/docker-orchagent/orchagent.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,15 @@ if [ ! -z "$HEARTBEAT_INTERVAL" ] && [ $HEARTBEAT_INTERVAL != "null" ]; then
ORCHAGENT_ARGS+=" -I $HEARTBEAT_INTERVAL"
fi

# Enable SAI MACSec POST when:
# - FIPS is enabled in SONiC (either in /proc/cmdline or /etc/fips/fips_enable); AND
# - MACSec is enabled on platform.
if grep -q "sonic_fips=1" /proc/cmdline || grep -q "1" /etc/fips/fips_enable ; then
if grep -q "macsec_enabled=1" /usr/share/sonic/platform/platform_env.conf 2>/dev/null ; then
Copy link
Contributor

@judyjoseph judyjoseph Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use source platform_env.conf or something line this https://github.com/criteo-forks/sonic-buildimage/blob/a9caf1152e1ed3d91cf7adf390dd89dfeb8602c5/files/scripts/asic_status.sh#L5

Copy link
Contributor Author

@ysmanman ysmanman Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @judyjoseph update review to source platform_env.conf as suggested.

ORCHAGENT_ARGS+=" -M"
fi
fi

# Mask SIGHUP signal to avoid orchagent termination by logrotate before orchagent registers its handler.
trap '' SIGHUP

Expand Down
Loading