Skip to content

Conversation

@yue-fred-gao
Copy link
Contributor

Why I did it

DPU in smartswitch uses dhcp to get ip for its midplane interface. The interface is only for management traffic. Data traffic should go through Ethernet interface, which is where the default route should be. So we should not install a default route by dhcp over the midplane interface. It will disrupt data traffic.

Work item tracking
  • Microsoft ADO (number only):

How I did it

Change dhcp server in smart-switch not to send "routers" option to dhcp client.

How to verify it

Reboot dpu or renew dhcp lease and verify no default route installed into dpu.

Which release branch to backport (provide reason below if selected)

  • 202205
  • 202211
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Tested branch (Please provide the tested image version)

  • SONiC.azure_cisco_master.0-dirty-20251106.125621

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@zjswhhh zjswhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KrisNey-MSFT
Copy link

hi @prsunny and @prabhataravind may we have a reviewer added please?

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prabhataravind
Copy link
Contributor

@yue-fred-gao I recall this was fixed in the past. See below PRs.

#21462
#21475

You can just remove the gateway config from smartswitch DHCP config and the default route should not get programmed. Could you check that instead of adding a smartswitch specific check?

Copy link
Contributor

@prabhataravind prabhataravind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we just remove gateway from smartswitch DHCP_SERVER_IPV4 default config?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants