-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Disable default route installed in dpu #24495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Disable default route installed in dpu #24495
Conversation
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
zjswhhh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
hi @prsunny and @prabhataravind may we have a reviewer added please? |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@yue-fred-gao I recall this was fixed in the past. See below PRs. You can just remove the gateway config from smartswitch DHCP config and the default route should not get programmed. Could you check that instead of adding a smartswitch specific check? |
prabhataravind
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we just remove gateway from smartswitch DHCP_SERVER_IPV4 default config?
Why I did it
DPU in smartswitch uses dhcp to get ip for its midplane interface. The interface is only for management traffic. Data traffic should go through Ethernet interface, which is where the default route should be. So we should not install a default route by dhcp over the midplane interface. It will disrupt data traffic.
Work item tracking
How I did it
Change dhcp server in smart-switch not to send "routers" option to dhcp client.
How to verify it
Reboot dpu or renew dhcp lease and verify no default route installed into dpu.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)