[build] Remove deprecated nodesource.com nodejs source from Bookworm slave container Dockerfile #24517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Debian Bookworm already has a nodejs that is newer than the nodesource.com version 14 that the Dockerfile is currently installing. Bookworm has nodejs 18. Because of this, we run the script (curl | bash) from nodesource.com for nodejs 14 which makes the process wait for 80 seconds because the script is deprecated. Then when we actually install nodejs, we get the version from Bookworm's repositories instead of nodesource.com anyway. This makes the process of using nodesource.com wasteful and pointless. The easy fix is to just remove this line where we add the nodesource repo.
nate-nexthop
force-pushed
the
nate.nodejs
branch
from
edd95db to
a4c3883
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nate-nexthop
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
We are attempting to install nodejs 14 from nodesource.com using this line in the Dockerfile:
However, this script is deprecated and because of this the script inserts artificial pauses so the user can heed their warning:
We need to stop using this script before it goes away as that will break builds. As it it, it wastes time.
Additionally, Bookworm has a Debian maintained nodejs, v18, which ends up being installed anyway because the sources added from nodesource.com are older.
Work item tracking
fixes #24516
How I did it
Just remove the line to add the nodesource.com APT sources.
How to verify it
Enter the sonic-slave-bash container before and after this change, and verify that the nodejs installed is v18:
Before:
After:
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
master
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)