[FRR] Allow proper shutdown of bgp dynamic peers #24961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vivekrnv
force-pushed
the
frr_dynamic_neigh_patch
branch
from
a74e30c to
985eea9
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@vivekrnv Please handle conflict. |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vivekrnv
force-pushed
the
frr_dynamic_neigh_patch
branch
from
a8f2312 to
213c4ba
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
vivekrnv
force-pushed
the
frr_dynamic_neigh_patch
branch
from
213c4ba to
f42b993
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dgsudharsan
approved these changes
Jan 16, 2026
Collaborator
|
@eddieruan-alibaba Can you please review? |
Collaborator
|
@vivekrnv please solve the conflicts |
Collaborator
|
@eddieruan-alibaba to review as Alibaba is the maintainer for this release. |
Collaborator
|
@GaladrielZhao can you review it ? |
Signed-off-by: Vivek Reddy <[email protected]>
vivekrnv
force-pushed
the
frr_dynamic_neigh_patch
branch
from
f42b993 to
a2b88c1
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
GaladrielZhao
approved these changes
Jan 22, 2026
Contributor
GaladrielZhao
left a comment
GaladrielZhao
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for the patch. This change has been backported to the FRR stable/10.4 branch.
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
eddieruan-alibaba
approved these changes
Jan 23, 2026
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Cannot be cherry picked until #25137 is merged |
Collaborator
|
@StormLiangMS Can you please help to review and signoff? |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vivekrnv
added
Request for 202511 Branch
and removed
Request for 202511 Branch
Cherry Pick Conflict_202511
labels
xincunli-sonic
pushed a commit
to xincunli-sonic/sonic-buildimage
that referenced
this pull request
Feb 2, 2026
- Why I did it In BGP scale setup with Dynamic peering enabled, sometimes we don't see output in "show ip bgp summary" however the peers are actually learnt - How I did it Port upstream FRR commit: FRRouting/frr@aadfa2b into SONIC - How to verify it Ported this fix and verified if it solves the problem Signed-off-by: Vivek Reddy <[email protected]> Signed-off-by: Xincun Li <[email protected]>
rameshraghupathy
pushed a commit
to rameshraghupathy/sonic-buildimage
that referenced
this pull request
Feb 3, 2026
- Why I did it In BGP scale setup with Dynamic peering enabled, sometimes we don't see output in "show ip bgp summary" however the peers are actually learnt - How I did it Port upstream FRR commit: FRRouting/frr@aadfa2b into SONIC - How to verify it Ported this fix and verified if it solves the problem Signed-off-by: Vivek Reddy <[email protected]> Signed-off-by: Ramesh Raghupathy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
In BGP scale setup with Dynamic peering enabled, sometimes we don't see output in "show ip bgp summary" however the peers are actually learnt
How I did it
Port upstream FRR commit: FRRouting/frr@aadfa2b into SONIC
How to verify it
Ported this fix and verified if it solves the problem
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)