Setting VxLAN decap TTL mode to pipe in configs generated from minigraphs
#24976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahdi Ramezani <[email protected]>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR configures VxLAN decapsulation TTL mode to pipe in configurations generated from minigraphs for devices with the "Appliance" resource type. This change ensures proper TTL handling for VxLAN tunnels on specific switch types.
Key Changes:
- Modified VxLAN tunnel configuration generation to include
ttl_mode: 'pipe'for appliance-type devices - Updated test expectations to validate the new ttl_mode field in generated configurations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/sonic-config-engine/minigraph.py |
Added ttl_mode: 'pipe' to VXLAN_TUNNEL configuration in parse_default_vxlan_decap function |
src/sonic-config-engine/tests/test_cfggen.py |
Updated test expectation to include the new ttl_mode field in VXLAN_TUNNEL output |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
To ensure that by default, the VxLAN decap TTL mode is set to
pipemodel in configs generated from minigraphs (for some switch types).Work item tracking
How I did it
Modified
minigraph.pyso that when theResourceTypein minigraph containsAppliance, thettl_modefor the generatedVXLAN_TUNNELtable is set topipe.How to verify it
Run
test_cfggen.py::TestCfgGen::test_minigraph_default_vxlan. This test has been modified accroding to the new changes.Which release branch to backport (provide reason below if selected)
The YANG model and SWSS changes are already merged for both master and 202511:
YANG model: #24657
SWSS: sonic-net/sonic-swss#3963
Tested branch (Please provide the tested image version)
Description for the changelog
Setting VxLAN decap TTL mode to
pipein configs generated from minigraphs.Link to config_db schema for YANG module changes
https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md#vxlan