[Nokia-7220 IXR]Add support for NOKIA 7220 IXR-H6-128#25653
Draft
fzhou-nokia wants to merge 2 commits intosonic-net:masterfrom
Draft
[Nokia-7220 IXR]Add support for NOKIA 7220 IXR-H6-128#25653fzhou-nokia wants to merge 2 commits intosonic-net:masterfrom
fzhou-nokia wants to merge 2 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds support for the Nokia 7220 IXR-H6-128 network switch platform to sonic-buildimage. The platform features 128x800G ports plus 2x25G management ports using a Broadcom Tomahawk6 (TH6) ASIC. The PR also updates buffer and PG profile configurations for the existing Nokia IXR7220-H6-64 platform to align with TH6 specifications (changing cell size from original values to 420 bytes).
Changes:
- Adds new platform directory device/nokia/x86_64-nokia_ixr7220_h6_128-r0 with complete platform configuration
- Integrates new platform into build system via platform/broadcom/platform-modules-nokia.mk and one-image.mk
- Updates existing H6-64 platform buffer and PG profile configurations to use TH6-appropriate values
Reviewed changes
Copilot reviewed 28 out of 30 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| platform/broadcom/platform-modules-nokia.mk | Adds build rules and version variables for H6-128 platform (contains critical truncation bug) |
| platform/broadcom/one-image.mk | Adds H6-128 module to image build |
| device/nokia/x86_64-nokia_ixr7220_h6_64-r0/Nokia-IXR7220-H6-64/pg_profile_lookup.ini | Updates PG profiles with TH6 cell size (420 bytes) and adjusted buffer values |
| device/nokia/x86_64-nokia_ixr7220_h6_64-r0/Nokia-IXR7220-H6-64/buffers_defaults_t1.j2 | Doubles xoff value from 29520896 to 59041792 for TH6 |
| device/nokia/x86_64-nokia_ixr7220_h6_64-r0/Nokia-IXR7220-H6-64/buffers_defaults_t0.j2 | Doubles xoff value from 29520896 to 59041792 for TH6 |
| device/nokia/x86_64-nokia_ixr7220_h6_128-r0/thermal_policy.json | Thermal management policy configuration (contains tab formatting issues) |
| device/nokia/x86_64-nokia_ixr7220_h6_128-r0/system_health_monitoring_config.json | System health monitoring configuration |
| device/nokia/x86_64-nokia_ixr7220_h6_128-r0/pmon_daemon_control.json | Platform monitoring daemon control settings |
| device/nokia/x86_64-nokia_ixr7220_h6_128-r0/plugins/led_control.py | LED control plugin implementation |
| device/nokia/x86_64-nokia_ixr7220_h6_128-r0/plugins/eeprom.py | EEPROM access plugin |
| device/nokia/x86_64-nokia_ixr7220_h6_128-r0/platform_env.conf | Platform environment configuration (syncd settings) |
| device/nokia/x86_64-nokia_ixr7220_h6_128-r0/platform_asic | ASIC type identifier (broadcom) |
| device/nokia/x86_64-nokia_ixr7220_h6_128-r0/pcie.yaml | PCIe device configuration for AMD Rembrandt platform |
| device/nokia/x86_64-nokia_ixr7220_h6_128-r0/led_proc_init.soc | LED processor initialization script |
| device/nokia/x86_64-nokia_ixr7220_h6_128-r0/installer.conf | ONIE installer configuration |
| device/nokia/x86_64-nokia_ixr7220_h6_128-r0/default_sku | Default SKU setting (Nokia-IXR7220-H6-128 t1) |
| device/nokia/x86_64-nokia_ixr7220_h6_128-r0/custom_led.bin | Binary LED firmware |
| device/nokia/x86_64-nokia_ixr7220_h6_128-r0/Nokia-IXR7220-H6-128/sai.profile | SAI profile pointing to h6-128.yml |
| device/nokia/x86_64-nokia_ixr7220_h6_128-r0/Nokia-IXR7220-H6-128/qos.json.j2 | QoS configuration template |
| device/nokia/x86_64-nokia_ixr7220_h6_128-r0/Nokia-IXR7220-H6-128/profile.ini | MAC address profile template |
| device/nokia/x86_64-nokia_ixr7220_h6_128-r0/Nokia-IXR7220-H6-128/port_config.ini | Port configuration for 128x800G + 2x25G ports |
| device/nokia/x86_64-nokia_ixr7220_h6_128-r0/Nokia-IXR7220-H6-128/pg_profile_lookup.ini | Priority group lossless profiles for TH6 |
| device/nokia/x86_64-nokia_ixr7220_h6_128-r0/Nokia-IXR7220-H6-128/hwsku.json | Hardware SKU with breakout mode definitions (contains tab formatting issue) |
| device/nokia/x86_64-nokia_ixr7220_h6_128-r0/Nokia-IXR7220-H6-128/h6-128.yml | Complete TH6 ASIC configuration with 128 port mappings (2210 lines) |
| device/nokia/x86_64-nokia_ixr7220_h6_128-r0/Nokia-IXR7220-H6-128/buffers_defaults_t1.j2 | T1 topology buffer configuration with increased pool sizes |
| device/nokia/x86_64-nokia_ixr7220_h6_128-r0/Nokia-IXR7220-H6-128/buffers_defaults_t0.j2 | T0 topology buffer configuration |
| device/nokia/x86_64-nokia_ixr7220_h6_128-r0/Nokia-IXR7220-H6-128/buffers_defaults_lt2.j2 | LT2 topology buffer configuration |
| device/nokia/x86_64-nokia_ixr7220_h6_128-r0/Nokia-IXR7220-H6-128/buffers.json.j2 | Buffer configuration template |
| device/nokia/x86_64-nokia_ixr7220_h6_128-r0/Nokia-IXR7220-H6-128/buffer_ports.j2 | Port list generation macro (contains port configuration mismatch bug) |
device/nokia/x86_64-nokia_ixr7220_h6_128-r0/Nokia-IXR7220-H6-128/hwsku.json
Outdated
Show resolved
Hide resolved
device/nokia/x86_64-nokia_ixr7220_h6_128-r0/thermal_policy.json
Outdated
Show resolved
Hide resolved
device/nokia/x86_64-nokia_ixr7220_h6_128-r0/Nokia-IXR7220-H6-128/buffer_ports.j2
Outdated
Show resolved
Hide resolved
device/nokia/x86_64-nokia_ixr7220_h6_128-r0/thermal_policy.json
Outdated
Show resolved
Hide resolved
fzhou-nokia
force-pushed
the
dev_h6_128
branch
from
e6d536a to
8b0b2d3
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines failed to run 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines failed to run 1 pipeline(s). |
fzhou-nokia
force-pushed
the
dev_h6_128
branch
from
9922085 to
c743df9
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines failed to run 1 pipeline(s). |
…tform Signed-off-by: y7zhou <yi.1.zhou@nokia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Add support for NOKIA 7220 IXR-H6-128 platforms:
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)