[initramfs-tools] Replace git clone with pinned tarball + SHA256#25664
Open
rustiqly wants to merge 1 commit intosonic-net:masterfrom
Open
[initramfs-tools] Replace git clone with pinned tarball + SHA256#25664rustiqly wants to merge 1 commit intosonic-net:masterfrom
rustiqly wants to merge 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
d60058b to
3e8bb9b
Compare
Replace the git clone from salsa.debian.org with a pinned tarball download and SHA256 checksum verification. This improves build reliability and reproducibility: - Eliminates dependency on salsa.debian.org git server availability (HTTP 502 errors have caused build failures) - Adds SHA256 integrity verification to detect corrupted downloads - Tarball download is faster than full git clone - Version is pinned via URL path and verified via checksum Signed-off-by: Rustiqly <rustiqly@users.noreply.github.com>
3e8bb9b to
9603593
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Replace the
git clonefromsalsa.debian.orgwith a pinned tarball download and SHA256 checksum verification.Why I did it
The initramfs-tools build fetches source via
git clonefrom Debian's GitLab instance (salsa.debian.org) during the build. This is fragile:This happened in practice — a transient salsa.debian.org 502 killed a 30-minute build that was almost done.
How I did it
27a78cc25a...) to ensure integritygit checkoutstep (tarball is already at the pinned version)How to verify it
The package should build identically to the git-clone version.