Skip to content

kdump-remote feature in hostcfgd #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 21, 2025
Merged

kdump-remote feature in hostcfgd #166

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2b481a4
kdump-remote feature in hostcfgd
muhammadalihussnain Sep 18, 2024
3f60bda
set values if remote enable
muhammadalihussnain Nov 26, 2024
be93fd2
set values if remote enable
muhammadalihussnain Nov 26, 2024
3417b5f
set values if remote enable
muhammadalihussnain Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 28 additions & 4 deletions scripts/hostcfgd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1134,9 +1134,14 @@ class SshServer(object):
class KdumpCfg(object):
def __init__(self, CfgDb):
self.config_db = CfgDb
self.kdump_defaults = { "enabled" : "false",
"memory": "0M-2G:256M,2G-4G:320M,4G-8G:384M,8G-:448M",
"num_dumps": "3" }
self.kdump_defaults = {
"enabled": "false",
"memory": "0M-2G:256M,2G-4G:320M,4G-8G:384M,8G-:448M",
"num_dumps": "3",
"remote": "false", # New feature: remote, default is "false"
"SSH_KEY": "<user@server>", # New feature: SSH key, default value
"SSH_PATH": "<path>" # New feature: SSH path, default value
}

def load(self, kdump_table):
"""
Expand All @@ -1147,7 +1152,7 @@ class KdumpCfg(object):
for row in self.kdump_defaults:
value = self.kdump_defaults.get(row)
if not kdump_conf.get(row):
self.config_db.mod_entry("KDUMP", "config", {row : value})
Copy link

@venkatmahalingam venkatmahalingam Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this change?

Copy link
Contributor

@ridahanif96 ridahanif96 Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is still there, it is not removed. Added Detail for remote configs here in kdump table
image

self.config_db.mod_entry("KDUMP", "config", {row: value})

def kdump_update(self, key, data):
syslog.syslog(syslog.LOG_INFO, "Kdump global configuration update")
Expand Down Expand Up @@ -1177,6 +1182,25 @@ class KdumpCfg(object):
num_dumps = data.get("num_dumps")
run_cmd(["sonic-kdump-config", "--num_dumps", num_dumps])

# Remote option
remote = self.kdump_defaults["remote"]
if data.get("remote") is not None:
remote = data.get("remote")
run_cmd(["sonic-kdump-config", "--remote", remote])

# SSH key
ssh_key = self.kdump_defaults["SSH_KEY"]
if data.get("SSH_KEY") is not None:
ssh_key = data.get("SSH_KEY")
run_cmd(["sonic-kdump-config", "--ssh_key", ssh_key])

# SSH path
ssh_path = self.kdump_defaults["SSH_PATH"]
if data.get("SSH_PATH") is not None:
ssh_path = data.get("SSH_PATH")
run_cmd(["sonic-kdump-config", "--ssh_path", ssh_path])
Copy link

@venkatmahalingam venkatmahalingam Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should we execute run_cmd with following defaults when KDUMP remote is not desired by the user?
SSH_KEY": "user@server", # New feature: SSH key, default value
"SSH_PATH": ""

Copy link
Contributor Author

@muhammadalihussnain muhammadalihussnain Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @venkatmahalingam i have update the code as suggested above .



class NtpCfg(object):
"""
NtpCfg Config Daemon
Expand Down