Skip to content

Conversation

@qiluo-msft
Copy link
Contributor

@qiluo-msft qiluo-msft commented Jun 2, 2025

Current slave image installs an old version.
files/build/versions/dockers/sonic-slave-bookworm/versions-py3:113:pygobject==3.42.2

Relax the install_requires range of PyGObject to allow any versions.

@mssonicbld
Copy link

/azp run

@qiluo-msft qiluo-msft requested a review from saiarcot895 June 2, 2025 18:37
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@qiluo-msft qiluo-msft enabled auto-merge (squash) June 2, 2025 18:53
@saiarcot895
Copy link
Contributor

Can we get rid of the version range requirement itself? I'm guessing that the code in this package wouldn't break if a version of pygobject newer than 3.50.0 were installed.

@qiluo-msft
Copy link
Contributor Author

Can we get rid of the version range requirement itself? I'm guessing that the code in this package wouldn't break if a version of pygobject newer than 3.50.0 were installed.

Reading #228, seems there is a good reason to limit <= 3.50.0

@mssonicbld
Copy link

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@qiluo-msft qiluo-msft disabled auto-merge June 2, 2025 20:34
@qiluo-msft qiluo-msft enabled auto-merge (squash) June 2, 2025 20:34
@qiluo-msft qiluo-msft merged commit 70de4d1 into sonic-net:master Jun 2, 2025
5 checks passed
@qiluo-msft qiluo-msft deleted the qiluo/PyGObject branch June 2, 2025 20:39
@mssonicbld
Copy link

Cherry-pick PR to 202505: #265

@mssonicbld
Copy link

Cherry-pick PR to 202411: #284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants