Skip to content

Integrated Security Cipher module with Hostcfgd for passkey decryption #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Integrated Security Cipher module with Hostcfgd for passkey decryption #274

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d76e5b
Integrated Security Cipher module with Hostcfgd for passkey decryption
nmoray-ebay Jun 25, 2025
ecce83f
Updated the check to avoid possible crash
nmoray-ebay Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions scripts/hostcfgd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ hostcfg_file_path = os.path.abspath(__file__)
hostcfg_dir_path = os.path.dirname(hostcfg_file_path)
sys.path.append(hostcfg_dir_path)
import ldap
from sonic_py_common.security_cipher import master_key_mgr

# FILE
PAM_AUTH_CONF = "/etc/pam.d/common-auth-sonic"
Expand Down Expand Up @@ -97,7 +98,6 @@ DEFAULT_FIPS_RESTART_SERVICES = ['ssh', 'telemetry.service', 'restapi']
CFG_DB = "CONFIG_DB"
STATE_DB = "STATE_DB"


def signal_handler(sig, frame):
if sig == signal.SIGHUP:
syslog.syslog(syslog.LOG_INFO, "HostCfgd: signal 'SIGHUP' is caught and ignoring..")
Expand Down Expand Up @@ -647,14 +647,20 @@ class AaaCfg(object):
src_ip = None

servers_conf = []
secure_cipher = master_key_mgr()
if self.tacplus_servers:
for addr in self.tacplus_servers:
server = tacplus_global.copy()
server['ip'] = addr
server.update(self.tacplus_servers[addr])
if 'key_encrypt' in server and server['key_encrypt'] == 'True':
output = secure_cipher.decrypt_passkey("TACPLUS", server['passkey'])
Copy link

@anders-nexthop anders-nexthop Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldnt this be TACPLUS_SERVER?

if output:
server['passkey'] = output
else:
syslog.syslog(syslog.LOG_ERR, "Decrypt_passkey failed for TACPLUS Server: {}.".format(addr))
servers_conf.append(server)
servers_conf = sorted(servers_conf, key=lambda t: int(t['priority']), reverse=True)

radius_global = self.radius_global_default.copy()
radius_global.update(self.radius_global)

Expand Down
Loading