Include info level logs in reboot cause services #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The committers listed above are authorized under a signed CLA. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @judyjoseph please take a look when you have time There is a mismatch between the comment and the functionality. In this PR we are updating the behavior to match the existing comment: Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
process-reboot-causeanddetermine-reboot-causeservices are filtering out INFO level logs. This is unintentional according to the comment "Configure logger to log all messages INFO level and higher".This PR calls
set_min_log_prioritywith logging.INFO (20) instead of sonic_logger.DEFAULT_LOG_LEVEL (21) as to not filter out the INFO logs.