tests: Ensure hostcfgd tests do not access /proc/cmdline #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some hostcfgd tests override contents of /proc/cmdline using various methods. In the remaining cases, actual /proc/cmdline from the host running the tests is opened and processed. For example, if `crashkernel=` is present on the test machine, a number of tests will try accessing config db table `KDUMP` and fail. To avoid influencing test results by the test environment, a new fixture is added to ensure reading /proc/cmdline returns an empty line by default. Signed-off-by: Krzysztof Kościuszkiewicz <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
We're seeing this issue too and this fix works for us. Can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some hostcfgd tests override contents of /proc/cmdline using various methods. In the remaining cases, actual /proc/cmdline from the host running the tests is opened and processed.
For example, if
crashkernel=is present on the test machine, a number of tests will try accessing config db tableKDUMPand fail.To avoid influencing test results by the test environment, a new fixture is added to ensure reading /proc/cmdline returns an empty line by default.