gNOI: Add backend support for Healthz #295
Open
+670
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Author
|
@rkavitha-hcl , @kanchanavelusamy could you please review the PR |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jayaragini-hcl
force-pushed
the
healthz_BE
branch
from
48c8300 to
6daea37
Compare
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
jayaragini-hcl
force-pushed
the
healthz_BE
branch
from
6daea37 to
33db184
Compare
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
jayaragini-hcl
force-pushed
the
healthz_BE
branch
from
33db184 to
60a2a39
Compare
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
jayaragini-hcl
force-pushed
the
healthz_BE
branch
from
60a2a39 to
70214f1
Compare
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
jayaragini-hcl
force-pushed
the
healthz_BE
branch
from
70214f1 to
864dd6a
Compare
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
jayaragini-hcl
force-pushed
the
healthz_BE
branch
from
864dd6a to
05d6ff3
Compare
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jayaragini-hcl
force-pushed
the
healthz_BE
branch
from
ac7064c to
3fcb0f1
Compare
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run |
This was referenced Nov 7, 2025
jayaragini-hcl
force-pushed
the
healthz_BE
branch
from
8364f05 to
2803691
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jayaragini-hcl
force-pushed
the
healthz_BE
branch
from
2803691 to
8ae7b94
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jayaragini-hcl
force-pushed
the
healthz_BE
branch
from
8ae7b94 to
7b2ac77
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Author
|
@kishanps , @magnusgao-google All the review comments have been addressed. Could you please review the updated PR and share your feedback? |
kishanps
approved these changes
Nov 11, 2025
scripts/sonic-host-server
Outdated
| gnoi_reset | ||
| ) | ||
|
|
||
| from host_modules import config_engine, debug_info, docker_service, file_service, gcu, host_service, image_service, reboot, showtech, systemd_service |
There was a problem hiding this comment.
Why is this changed and I see gnoi_reset missing.
| 'file_stat': file_service.FileService('file'), | ||
| 'debug_service': debug_service.DebugExecutor('DebugExecutor'), | ||
| 'gnoi_reset': gnoi_reset.GnoiReset('gnoi_reset') | ||
| 'debug_info': debug_info.DebugInfo('debug_info') |
There was a problem hiding this comment.
Isn't debug_service different than debug_info ? Why are we removing debug_service ?
gnoi_reset is missing here too.
jayaragini-hcl
force-pushed
the
healthz_BE
branch
from
7b2ac77 to
dff23ad
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jayaragini-hcl
force-pushed
the
healthz_BE
branch
from
dff23ad to
ba14770
Compare
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
jayaragini-hcl
force-pushed
the
healthz_BE
branch
from
ba14770 to
e917e52
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jayaragini-hcl
force-pushed
the
healthz_BE
branch
from
e917e52 to
1d5479e
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the backend support for gNOI Healthz. However, since the necessary consumer logic for receiving and executing debug requests is currently absent within the upstream SONiC component containers, the current backend implementation only supports Host-level artifact collection. This involves running common debug commands directly on the host and generating the resulting *.tar.gz file, excluding component-specific debug data.
NOTE: All the Functionality testing has been done on SONiC Virtual Switch.
Below is the placeholder for Artifact tar file and the list of files
Dependent FE PRs
sonic-net/sonic-gnmi#485
sonic-net/sonic-gnmi#486
sonic-net/sonic-gnmi#507
sonic-net/sonic-gnmi#487
sonic-net/sonic-gnmi#488
sonic-net/sonic-gnmi#489
sonic-net/sonic-gnmi#509