-
Notifications
You must be signed in to change notification settings - Fork 134
[BugFix]hostcfgd,mgmt interface IP cannot be deleted IF gw wasn't given during config. #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ashutosh-cs
wants to merge
4
commits into
sonic-net:master
Choose a base branch
from
ashutosh-cs:FixMgmtIpDel
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When configuring a static IP on the management interface without a default gateway address, the static IP cannot be deleted.
This issue occurs due to how the data is handled in
update_mgmt_iface().This function is responsible for configuring and triggering a restart of
interfaces-config.service.This issue can occur during different scneraios like
config interface ip add <interface_name> <ip_addr> [default_gw]
config interface ip remove <interface_name> <ip_addr> [default_gw]
sudo config interface ip add eth0 3002::8/64
Fix
The fix updates the logic in
update_mgmt_iface()to properly manage changes to a management interface’s configuration:not data), it removes the existing entry for that key and logs the removal.