[action] [PR:237] [kdump-config] Update kdump default config with pre-defined value in /proc/cmdline (installer.conf)

[mssonicbld]

Why I did it

Modify the hostcfgd to handle the kdump enabled to the CONFIG_DB when kdump is enabled by default in the platform installer.conf . Related PR for 202405 is: #236

How I did it

Added a new method init_kdump_config_from_cmdline() in the KdumpCfg class to check the /proc/cmdline. If key "crashkernel=" exists in /proc/cmdline when system is up, this means that the kdump is enabled. init_kdump_config_from_cmdline() will update the kdump_defaults and CONFIG_DB when if the current config data are not matched the pre-defined data in the /proc/cmdline. This happens during a new image upgrade with the crashkernel is defined the platform installer.conf.

How to verify it

1. install an image with predefine kdump enabled in the grub.conf.
2. execute the "config load_minigraph"
   • check it should not any error in the syslog
   • After the hostcfgd is running, execute "show kdump config" should show kdump is enabled. Output as below

admin@sonic:~$ show kdump config
Kdump administrative mode: Enabled
Kdump operational mode: Ready
Kdump memory reservation: 8G-:1G
Maximum number of Kdump files: 3

3. save config and reboot the system
4. show command should show the kdump is enabled and also there should not be any kdump/hostcfgd error log in syslog

Which release branch to backport (provide reason below if selected)

• 201811
• 201911
• 202006
• 202012
• 202106
• 202111
• 202205
• 202211
• 202305
• 202405

[mssonicbld]

Original PR: #237

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[tjchadaga]

@arista-nwolfe, @mlok-nokia - could you help check the UT failures on this?

[arista-nwolfe]

@arista-nwolfe, @mlok-nokia - could you help check the UT failures on this?

AssertionError: 'check_call' does not contain all of (call(['sonic-kdump-config', '--remote', 'false']), call(['sonic-kdump-config', '--ssh_string', 'user@localhost']), call(['sonic-kdump-config', '--ssh_path', '/a/b/c'])) in its call list, found [] instead

It looks like the PRs which added the arguments --remote --ssh_string and --ssh_path aren't in msft_202503
#166
#216
#209

You'll probably need to remove those expected calls from the test case

                call(['sonic-kdump-config', '--remote', 'false']),  # Covering remote
                call(['sonic-kdump-config', '--ssh_string', 'user@localhost']),  # Covering ssh_string
                call(['sonic-kdump-config', '--ssh_path', '/a/b/c'])  # Covering ssh_path

[mlok-nokia]

@arista-nwolfe, @mlok-nokia - could you help check the UT failures on this?

AssertionError: 'check_call' does not contain all of (call(['sonic-kdump-config', '--remote', 'false']), call(['sonic-kdump-config', '--ssh_string', 'user@localhost']), call(['sonic-kdump-config', '--ssh_path', '/a/b/c'])) in its call list, found [] instead

It looks like the PRs which added the arguments --remote --ssh_string and --ssh_path aren't in msft_202503 #166 #216 #209

You'll probably need to remove those expected calls from the test case

                call(['sonic-kdump-config', '--remote', 'false']),  # Covering remote
                call(['sonic-kdump-config', '--ssh_string', 'user@localhost']),  # Covering ssh_string
                call(['sonic-kdump-config', '--ssh_path', '/a/b/c'])  # Covering ssh_path

Correct. These 3 default setting are not in 202503 branch.

            "remote": "false",            # New feature: remote, default is "false"
            "ssh_string": "user@localhost",   # New feature: SSH key, default value
            "ssh_path": "/a/b/c"          # New feature: SSH path, default value

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).