Draft
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jasper-hou-micas
force-pushed
the
igmp-snp
branch
from
5a08a8f to
c626b0d
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Jasper.Hou <jasper@micasnetworks.com>
Signed-off-by: Jasper.Hou <jasper@micasnetworks.com>
jasper-hou-micas
force-pushed
the
igmp-snp
branch
from
c626b0d to
a52d847
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
aidan-gallagher
left a comment
aidan-gallagher
left a comment
There was a problem hiding this comment.
This PR adds sonic-igmp-snooping.yang and sonic-mld-snooping.yang imports to import.mk. The YANG model files themselves live in the companion buildimage PR #24327, where the detailed YANG review comments have been posted.
Summary of YANG issues (see buildimage #24327 for inline details):
- CRLF line endings in
sonic-igmp-snooping.yang(Critical) - Both modules use the same prefix
sigmps(High) - Deprecated Azure namespace instead of sonic-net (High)
- Redundant leaves (
out-intf/port,mrouter-intf/mrouter_port) (High) - Mixed hyphens and underscores in leaf names (Medium)
- Missing
unitson timer leaves (Medium) - Circular
mustconstraints with incorrect error message (Medium) - MLD model missing
L2MC_SUPPRESSequivalent (Medium)
| Critical | High | Medium | Low | Total |
|---|---|---|---|---|
| 1 | 4 | 5 | 5 | 15 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add igmp and mld snooping yang model for restconf
Dependency
This PR is part of the "L2MC-Snooping" series.
It depends on PRs: