Open
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
niranjanivivek
force-pushed
the
rcm_pr_be
branch
from
e10d929 to
abe0442
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
niranjanivivek
force-pushed
the
rcm_pr_be
branch
from
abe0442 to
6ca8a9f
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
niranjanivivek
force-pushed
the
rcm_pr_be
branch
from
6ca8a9f to
a73de8d
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@sreeiyer-1 Please review and provide feedback |
Contributor
Author
niranjanivivek
force-pushed
the
rcm_pr_be
branch
from
a73de8d to
e1fe88c
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
niranjanivivek
force-pushed
the
rcm_pr_be
branch
from
e1fe88c to
e4096cc
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
niranjanivivek
force-pushed
the
rcm_pr_be
branch
from
e4096cc to
e25c03a
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
niranjanivivek
force-pushed
the
rcm_pr_be
branch
from
e25c03a to
7ba8e6a
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ndas7
suggested changes
Jan 28, 2026
niranjanivivek
force-pushed
the
rcm_pr_be
branch
from
7ba8e6a to
657eaaf
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
niranjanivivek
force-pushed
the
rcm_pr_be
branch
from
657eaaf to
29b4c96
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
niranjanivivek
force-pushed
the
rcm_pr_be
branch
from
fc8a2cb to
e47d118
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
niranjanivivek
force-pushed
the
rcm_pr_be
branch
from
e47d118 to
249f684
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
niranjanivivek
force-pushed
the
rcm_pr_be
branch
from
249f684 to
9b3ab81
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
niranjanivivek
force-pushed
the
rcm_pr_be
branch
from
9b3ab81 to
9b3ed5a
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
niranjanivivek
force-pushed
the
rcm_pr_be
branch
from
9b3ed5a to
cba4379
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
niranjanivivek
force-pushed
the
rcm_pr_be
branch
from
cba4379 to
325dc64
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@sreeiyer-1, @jayaragini-hcl Please review. |
Contributor
Author
ndas7
reviewed
Mar 2, 2026
| SnmpDB // 7 | ||
| ErrorDB // 8 | ||
| EventDB // 9 | ||
| ApplStateDB DBNum = 14 // 14 |
Contributor
There was a problem hiding this comment.
ApplStateDB is not needed, please remove this and its instances
ndas7
reviewed
Mar 2, 2026
| // match the given pattern if the table is only supposed to be read from the cache. | ||
| // Otherwise, GetKeysPattern is called. This is used to serve OnChange subscriptions using the state | ||
| // of the OnChange cache without allowing cache updates from transformers. | ||
| func (d *DB) GetKeysPatternWithOnChangeCache(ts *TableSpec, pat Key) ([]Key, error) { |
Contributor
There was a problem hiding this comment.
This is not used, please remove
| glog.Info("CommitTx: Begin:") | ||
| } | ||
|
|
||
| func doDels(txCmds []_txCmd, tsmap map[TableSpec]bool, d *DB) error { |
Contributor
There was a problem hiding this comment.
These functions are unrelated to the change, please only keep relevant changes
|
|
||
| // For each cmd in txCmds | ||
| // Invoke it | ||
| func doRemainingOps(txCmds []_txCmd, tsmap map[TableSpec]bool, d *DB) error { |
Contributor
There was a problem hiding this comment.
Same as above - These functions are unrelated to the change, please only keep relevant changes
| goto CommitTxDiscard | ||
| } | ||
|
|
||
| // Pass through txCmds twice, processing table deletes on the first pass. |
Signed-off-by: Niranjani Vivek <niranjaniv@google.com>
niranjanivivek
force-pushed
the
rcm_pr_be
branch
from
325dc64 to
7be1a2f
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the code using Redis connection pools to connect to Redis from within sonic-mgmt-common.
The idea is Redis Clients with a connection pool must be reused, instead of creating a new Redis Client each time.,
HLD Reference: HLD