Open
Conversation
added 2 commits
June 3, 2021 01:54
Signed-off-by: spenugondaa <srinadh.penugondaa@dell.com>
Signed-off-by: spenugondaa <srinadh.penugondaa@dell.com>
This was referenced Jun 7, 2021
| ) | ||
|
|
||
| func init() { | ||
| XlateFuncBind("DbToYang_event_severity_xfmr", DbToYang_event_severity_xfmr) |
Contributor
There was a problem hiding this comment.
I do not see event_severity_xfmr in any annotation file. Did we miss the corresponding YANG and annotation file?
| @@ -0,0 +1,39 @@ | |||
| module sonic-alarm-annot { | |||
Contributor
There was a problem hiding this comment.
All sonic yangs need to be in the buildimage folder.
| XlateFuncBind("rpc_acknowledge_alarms", rpc_acknowledge_alarms) | ||
| XlateFuncBind("rpc_get_events", rpc_get_events) | ||
| XlateFuncBind("rpc_get_alarms", rpc_get_alarms) | ||
| XlateFuncBind("YangToDb_event_stats_key_xfmr", YangToDb_event_stats_key_xfmr) |
Contributor
There was a problem hiding this comment.
Why do we need event_stats_key_xfmr if the two functions does not do anything? Where is this defined in annotation file?
dell-engops
pushed a commit
to project-arlo/sonic-mgmt-common
that referenced
this pull request
Feb 14, 2022
…a logging enhancements to improve debuggability - (sonic-net#48) * Xfmr infra logging enhancements to improve debuggability - Log in/out messages/params from overloaded xfmr callbacks * Addressed code review comment to change log messsages around callbacks to have before and after
Contributor
|
Is this PR obsolete, or does it need to be rebased to reflect the changes for the previous comments? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is dependent on PR and follows the HLD
The changes involve yang definitions and transformer changes to support various show/exec commands. Translib code is updated with the new DB. A go library to raise events/alarms is introduced.
Dependent PRs:
sonic-buildimage
sonic-swss-common
sonic-mgmt-framework