Skip to content

Fixing import issue for fixture is_pfc_enabled #21313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 18, 2025
Merged

Fixing import issue for fixture is_pfc_enabled #21313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68e85b9
is_pfc_enabled
vikumarks Nov 13, 2025
15e2934
Merge branch 'sonic-net:master' into pfc_testcase_fixes
vikumarks Nov 14, 2025
84cd14c
missed one file update
vikumarks Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/common/snappi_tests/common_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,8 +547,8 @@ def enable_ecn(host_ans, prio, asic_value=None):
"""
if asic_value is None:
host_ans.shell('sudo ecnconfig -q {} on'.format(prio))
results = host_ans.shell('ecnconfig -q {}'.format(prio))
if re.search("queue {}: on".format(prio), results['stdout']):
results = host_ans.shell('sudo ecnconfig -q {} on'.format(prio))
if re.search("sudo ecnconfig -q {} on".format(prio), results['cmd']):
return True
else:
host_ans.shell('sudo ecnconfig -n {} -q {} on'.format(asic_value, prio))
Expand Down
2 changes: 1 addition & 1 deletion tests/snappi_tests/pfc/test_pfc_pause_response_with_snappi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from tests.common.fixtures.conn_graph_facts import conn_graph_facts,\
fanout_graph_facts # noqa: F401
from tests.common.snappi_tests.snappi_fixtures import snappi_api_serv_ip, snappi_api_serv_port,\
snappi_api, snappi_testbed_config # noqa: F401
snappi_api, snappi_testbed_config, is_pfc_enabled # noqa: F401
from tests.common.snappi_tests.qos_fixtures import prio_dscp_map, all_prio_list, lossless_prio_list,\
lossy_prio_list, disable_pfcwd # noqa: F401
from tests.common.snappi_tests.snappi_test_params import SnappiTestParams
Expand Down
2 changes: 1 addition & 1 deletion tests/snappi_tests/pfc/test_pfc_pause_unset_bit_enable_vector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from tests.common.fixtures.conn_graph_facts import conn_graph_facts,\
fanout_graph_facts # noqa: F401
from tests.common.snappi_tests.snappi_fixtures import snappi_api_serv_ip, snappi_api_serv_port,\
snappi_api, snappi_testbed_config # noqa: F401
snappi_api, snappi_testbed_config, is_pfc_enabled # noqa: F401
from tests.common.snappi_tests.qos_fixtures import prio_dscp_map, all_prio_list, lossless_prio_list,\
lossy_prio_list, disable_pfcwd # noqa: F401
from tests.common.snappi_tests.snappi_test_params import SnappiTestParams
Expand Down
2 changes: 1 addition & 1 deletion tests/snappi_tests/pfc/test_pfc_pause_zero_mac.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from tests.common.fixtures.conn_graph_facts import conn_graph_facts,\
fanout_graph_facts # noqa: F401
from tests.common.snappi_tests.snappi_fixtures import snappi_api_serv_ip, snappi_api_serv_port,\
snappi_api, snappi_testbed_config # noqa: F401
snappi_api, snappi_testbed_config, is_pfc_enabled # noqa: F401
from tests.common.snappi_tests.qos_fixtures import prio_dscp_map, all_prio_list, lossless_prio_list,\
lossy_prio_list, disable_pfcwd # noqa: F401
from tests.common.snappi_tests.snappi_test_params import SnappiTestParams
Expand Down
2 changes: 1 addition & 1 deletion tests/snappi_tests/pfc/test_valid_pfc_frame_with_snappi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from tests.common.fixtures.conn_graph_facts import conn_graph_facts,\
fanout_graph_facts # noqa: F401
from tests.common.snappi_tests.snappi_fixtures import snappi_api_serv_ip, snappi_api_serv_port,\
snappi_api, snappi_testbed_config # noqa: F401
snappi_api, snappi_testbed_config, is_pfc_enabled # noqa: F401
from tests.common.snappi_tests.qos_fixtures import prio_dscp_map, all_prio_list, lossless_prio_list,\
lossy_prio_list, disable_pfcwd # noqa: F401
from tests.common.snappi_tests.snappi_test_params import SnappiTestParams
Expand Down
2 changes: 1 addition & 1 deletion tests/snappi_tests/pfc/test_valid_src_mac_pfc_frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from tests.common.fixtures.conn_graph_facts import conn_graph_facts,\
fanout_graph_facts # noqa: F401
from tests.common.snappi_tests.snappi_fixtures import snappi_api_serv_ip, snappi_api_serv_port,\
snappi_api, snappi_testbed_config, is_snappi_multidut # noqa: F401
snappi_api, snappi_testbed_config, is_snappi_multidut, is_pfc_enabled # noqa: F401
from tests.common.snappi_tests.qos_fixtures import prio_dscp_map, all_prio_list, lossless_prio_list,\
lossy_prio_list, disable_pfcwd # noqa: F401
from tests.common.snappi_tests.snappi_test_params import SnappiTestParams
Expand Down
2 changes: 1 addition & 1 deletion tests/snappi_tests/pfc/warm_reboot/test_pfc_pause_lossless_warm_reboot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from tests.common.fixtures.conn_graph_facts import conn_graph_facts,\
fanout_graph_facts # noqa: F401
from tests.common.snappi_tests.snappi_fixtures import snappi_api_serv_ip, snappi_api_serv_port,\
snappi_api, snappi_testbed_config # noqa: F401
snappi_api, snappi_testbed_config, is_pfc_enabled # noqa: F401
from tests.common.snappi_tests.qos_fixtures import prio_dscp_map, all_prio_list, lossless_prio_list,\
lossy_prio_list # noqa: F401
from tests.common.snappi_tests.snappi_test_params import SnappiTestParams
Expand Down
Loading