Support multi-chip in packet trimming tests with refactor #21318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Packet trimming configuration depends on the chip, but currently everything is based on constants. In order to support multiple chips we should refactor all packet trimming configuration to retrieve values through functions that check the asic name in duthost.
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Packet trimming tests today are written with only small set of chips in mind. The test uses constants for all configuration values. In an effort to support packet trimming on Arista Quicksilver512, we found these constants did not work to configure the chip.
How did you do it?
Refactored any config related constants into functions that are accessed through the class
PacketTrimmingConfig. These static methods requireduthostto be passed in such that values returned can be based onduthost.get_asic_name().How did you verify/test it?
We have been running packet trimming tests internally with this refactor and have sorted out any failures related to this refactor.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation