[Nexthop] Inject ipinip packet instead of the inner packet in test_fib ipinip tests #21838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run |
github-actions
bot
requested review from
mramezani95,
xwjiang-ms and
zypgithub
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: venu-nexthop <venu@nexthop.ai>
venu-nexthop
force-pushed
the
venu-fib-ipinip-1
branch
from
e3ca78c to
a61c345
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
Hi @gshemesh2 , looks like the previous change was made by PR #17503. |
Contributor
Author
|
Fixed by #21731 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
In IPinIP tests with some recent changes upstream the packet being injected is changed from the constructed ipinip packet to the inner packet. This is causing the expected packet not to be seen on the DUT. Need to revert to the previous behavior.
Summary:
Fixes # (issue)
21837
#21837
Type of change
Back port request
Approach
What is the motivation for this PR?
To fix test_fib: test_ipinip_hash, test_ipinip_hash_negative tests
How did you do it?
Correct the packet to be injected in the above tests
How did you verify/test it?
Tests pass with this fix
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation