[Nvidia] Increase the pre_reboot_timeout in fwutil ONIE/BIOS test for SN4280 #21849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The switch shutdown time for SN4280 is longer due to PR:sonic-net/sonic-buildimage#24165. We need increase the timeout. Previousl we added this change only to 202506 branch, but now we decide add it to master regradless of the status of sonic-buildimage PR#24165 status in master branch. This is because the reboot time for SN4280 will be longer anyway due to the DPUs. Signed-off-by: Cong Hou <congh@nvidia.com>
Collaborator
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
nhe-NV
approved these changes
Jan 7, 2026
nhe-NV
added
the
Request for 202511 branch
Contributor
|
Close/re-open for PR test infra issue |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nhe-NV
approved these changes
Jan 10, 2026
roy-sror
requested changes
Jan 22, 2026
| else: | ||
| # For BIOS/ONIE, most time is spend after the reboot in ONIE | ||
| pre_reboot_timeout = 120 | ||
| if duthost.facts["platform"] == "x86_64-nvidia_sn4280-r0": |
Contributor
There was a problem hiding this comment.
if this impacts any SmartSwitch system, then we should have a funtion that identifies any SmartSwitch function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
The switch shutdown time for SN4280 is longer due to PR:sonic-net/sonic-buildimage#24165.
We need increase the pre_reboot_timeout timeout.
Previously, we have already added this change but only in 202506 branch.
Now we decided add it also to master branch regardless of the status of sonic-buildimage PR#24165.
This is because the reboot time for SN4280 will be longer anyway due to the DPUs.
Type of change
Back port request
Approach
What is the motivation for this PR?
Make sure the fwutil ONIE/BIOS is stable on SN4280 when the DPUs are online.
How did you do it?
Add a additional 240s in the pre_reboot_timeout.
How did you verify/test it?
Run the test on SN4280 light mode regression, it's passing consistently.
Any platform specific information?
Only for SN4280
Supported testbed topology if it's a new test case?
Documentation