[action] [PR:21830] Fix TyperError in test_ecmp_balance.py due to function in utilities.py modified #21853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…py modified (sonic-net#21830) What is the motivation for this PR? Update the get_downstream_neigh_type function parameter which was modified by other PR. How did you do it? Use tbinfo instead of topy_type How did you verify/test it? Run test_ecmp_balance.py test evidence: https://elastictest.org/scheduler/testplan/695c7df5ed78cb175048b503?testcase=ecmp%2Ftest_ecmp_balance.py&type=console ============================= test session starts ============================== platform linux -- Python 3.12.3, pytest-9.0.2, pluggy-1.6.0 ansible: 2.18.12 rootdir: /var/src/sonic-mgmt_vms64-t1-7260-14/tests configfile: pytest.ini plugins: cov-7.0.0, stress-1.0.1, sugar-1.1.1, xdist-3.8.0, plus-0.8.1, allure-pytest-2.15.2, html-4.1.1, repeat-0.9.4, metadata-3.1.1, ansible-25.12.0 collected 4 items ecmp/test_ecmp_balance.py::test_udp_packets[ipv4] PASSED [ 25%] ecmp/test_ecmp_balance.py::test_udp_packets_ecmp[ipv4] PASSED [ 50%] ecmp/test_ecmp_balance.py::test_udp_packets[ipv6] PASSED [ 75%] ecmp/test_ecmp_balance.py::test_udp_packets_ecmp[ipv6] PASSED [100%]DEBUG:tests.conftest:[log_custom_msg] item: <Function test_udp_packets_ecmp[ipv6]> INFO:root:Can not get Allure report URL. Please check logs
12 tasks
Collaborator
Author
|
Original PR: #21830 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vmittal-msft
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Those
Due to #20620, the
get_upstream_neigh_typeinutilities.pywas modified.I fixed it in #21488
Then
get_downstream_neigh_typewas modified again in #20913I have to modify the parameter again.
Type of change
Back port request
Approach
What is the motivation for this PR?
Update the
get_downstream_neigh_typefunction parameter which was modified by other PR.How did you do it?
Use tbinfo instead of topy_type
How did you verify/test it?
Run
test_ecmp_balance.pytest evidence:
https://elastictest.org/scheduler/testplan/695c7df5ed78cb175048b503?testcase=ecmp%2Ftest_ecmp_balance.py&type=console
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation