-
Notifications
You must be signed in to change notification settings - Fork 935
Remove CODEOWNERS after auto reviewer assign is added #21862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This repo has enabled auto code reviewer assign according to the git history. The .github/CODEOWNERS file is now outdated and not necessary. This change deleted this .github/CODEOWNERS file. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
roy-sror
approved these changes
Jan 8, 2026
Collaborator
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Collaborator
|
hi @wangxin For the auto-assignment, could you clarify the mechanism in a bit more detail? Specifically, what are the reasons for moving away from the current approach? |
Collaborator
Author
|
Hi @StormLiangMS, I have just added background to the PR description. |
StormLiangMS
approved these changes
Jan 13, 2026
Collaborator
StormLiangMS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Collaborator
|
@yxieca any thoughts? |
PriyanshTratiya
pushed a commit
to PriyanshTratiya/sonic-mgmt
that referenced
this pull request
Jan 21, 2026
What is the motivation for this PR? This repo has enabled auto code reviewer assign according to the git history. The .github/CODEOWNERS file is now outdated and not necessary. Background of auto code reviewer assign It is tedious to manually maintain the CODEOWNERS file. @nikamirrr from Nvidia contributed auto code reviewer assign workflow: https://github.com/sonic-net/sonic-mgmt/actions/workflows/code-reviewer-tagging.yml This automation automatically check git history of files updated by PR. Find out the previous contributors of the touched files and assign them as reviewer of the PR. This automation has 2 major benefits: No need to manually maintain the CODEOWNERS file. Automatically find the most appropriate owners/reviewers. Not able to find appropriate owner of code has been a pain point of community for quite some time. For details, please refer to https://github.com/sonic-net/sonic-pipelines/tree/main/scripts/code-owners How did you do it? This change deleted this .github/CODEOWNERS file. Signed-off-by: Xin Wang <xiwang5@microsoft.com> Signed-off-by: Priyansh Tratiya <ptratiya@microsoft.com>
saravanan-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Jan 22, 2026
What is the motivation for this PR? This repo has enabled auto code reviewer assign according to the git history. The .github/CODEOWNERS file is now outdated and not necessary. Background of auto code reviewer assign It is tedious to manually maintain the CODEOWNERS file. @nikamirrr from Nvidia contributed auto code reviewer assign workflow: https://github.com/sonic-net/sonic-mgmt/actions/workflows/code-reviewer-tagging.yml This automation automatically check git history of files updated by PR. Find out the previous contributors of the touched files and assign them as reviewer of the PR. This automation has 2 major benefits: No need to manually maintain the CODEOWNERS file. Automatically find the most appropriate owners/reviewers. Not able to find appropriate owner of code has been a pain point of community for quite some time. For details, please refer to https://github.com/sonic-net/sonic-pipelines/tree/main/scripts/code-owners How did you do it? This change deleted this .github/CODEOWNERS file. Signed-off-by: Xin Wang <xiwang5@microsoft.com> Signed-off-by: Saravanan Sellappa <saravanan@nexthop.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
This repo has enabled auto code reviewer assign according to the git history. The .github/CODEOWNERS file is now outdated and not necessary.
Background of auto code reviewer assign
It is tedious to manually maintain the CODEOWNERS file. @nikamirrr from Nvidia contributed auto code reviewer assign workflow: https://github.com/sonic-net/sonic-mgmt/actions/workflows/code-reviewer-tagging.yml
This automation automatically check git history of files updated by PR. Find out the previous contributors of the touched files and assign them as reviewer of the PR.
This automation has 2 major benefits:
For details, please refer to https://github.com/sonic-net/sonic-pipelines/tree/main/scripts/code-owners
How did you do it?
This change deleted this .github/CODEOWNERS file.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation