Skip to content

Conversation

@wangxin
Copy link
Collaborator

@wangxin wangxin commented Jan 8, 2026

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505
  • 202511

Approach

What is the motivation for this PR?

This repo has enabled auto code reviewer assign according to the git history. The .github/CODEOWNERS file is now outdated and not necessary.

Background of auto code reviewer assign
It is tedious to manually maintain the CODEOWNERS file. @nikamirrr from Nvidia contributed auto code reviewer assign workflow: https://github.com/sonic-net/sonic-mgmt/actions/workflows/code-reviewer-tagging.yml

This automation automatically check git history of files updated by PR. Find out the previous contributors of the touched files and assign them as reviewer of the PR.

This automation has 2 major benefits:

  1. No need to manually maintain the CODEOWNERS file.
  2. Automatically find the most appropriate owners/reviewers. Not able to find appropriate owner of code has been a pain point of community for quite some time.

For details, please refer to https://github.com/sonic-net/sonic-pipelines/tree/main/scripts/code-owners

How did you do it?

This change deleted this .github/CODEOWNERS file.

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

This repo has enabled auto code reviewer assign according to the git history. The .github/CODEOWNERS file is now outdated and not necessary. This change deleted this .github/CODEOWNERS file.

Signed-off-by: Xin Wang <xiwang5@microsoft.com>
@wangxin wangxin requested review from nikamirrr and roy-sror January 8, 2026 08:02
@wangxin wangxin requested a review from a team as a code owner January 8, 2026 08:02
@StormLiangMS
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@StormLiangMS
Copy link
Collaborator

StormLiangMS commented Jan 13, 2026

hi @wangxin For the auto-assignment, could you clarify the mechanism in a bit more detail? Specifically, what are the reasons for moving away from the current approach?

@wangxin
Copy link
Collaborator Author

wangxin commented Jan 13, 2026

Hi @StormLiangMS, I have just added background to the PR description.

Copy link
Collaborator

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS
Copy link
Collaborator

@yxieca any thoughts?

@wangxin wangxin merged commit 30af803 into sonic-net:master Jan 20, 2026
6 checks passed
PriyanshTratiya pushed a commit to PriyanshTratiya/sonic-mgmt that referenced this pull request Jan 21, 2026
What is the motivation for this PR?
This repo has enabled auto code reviewer assign according to the git history. The .github/CODEOWNERS file is now outdated and not necessary.

Background of auto code reviewer assign
It is tedious to manually maintain the CODEOWNERS file. @nikamirrr from Nvidia contributed auto code reviewer assign workflow: https://github.com/sonic-net/sonic-mgmt/actions/workflows/code-reviewer-tagging.yml

This automation automatically check git history of files updated by PR. Find out the previous contributors of the touched files and assign them as reviewer of the PR.

This automation has 2 major benefits:

No need to manually maintain the CODEOWNERS file.
Automatically find the most appropriate owners/reviewers. Not able to find appropriate owner of code has been a pain point of community for quite some time.
For details, please refer to https://github.com/sonic-net/sonic-pipelines/tree/main/scripts/code-owners

How did you do it?
This change deleted this .github/CODEOWNERS file.

Signed-off-by: Xin Wang <xiwang5@microsoft.com>
Signed-off-by: Priyansh Tratiya <ptratiya@microsoft.com>
saravanan-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Jan 22, 2026
What is the motivation for this PR?
This repo has enabled auto code reviewer assign according to the git history. The .github/CODEOWNERS file is now outdated and not necessary.

Background of auto code reviewer assign
It is tedious to manually maintain the CODEOWNERS file. @nikamirrr from Nvidia contributed auto code reviewer assign workflow: https://github.com/sonic-net/sonic-mgmt/actions/workflows/code-reviewer-tagging.yml

This automation automatically check git history of files updated by PR. Find out the previous contributors of the touched files and assign them as reviewer of the PR.

This automation has 2 major benefits:

No need to manually maintain the CODEOWNERS file.
Automatically find the most appropriate owners/reviewers. Not able to find appropriate owner of code has been a pain point of community for quite some time.
For details, please refer to https://github.com/sonic-net/sonic-pipelines/tree/main/scripts/code-owners

How did you do it?
This change deleted this .github/CODEOWNERS file.

Signed-off-by: Xin Wang <xiwang5@microsoft.com>
Signed-off-by: Saravanan Sellappa <saravanan@nexthop.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants