Skip to content

Added WDC ssd health #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Added WDC ssd health #300

Changes from 3 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e19f696
added support for WDC SDASN8Y1T00 SSD health
yurixsight Sep 23, 2021
f459e81
Merge branch 'master' into xsight-platform-dev
prgeor Dec 1, 2023
b0408c9
Merge branch 'master' into xsight-platform-dev
prgeor Jan 24, 2024
c39fb40
Merge branch 'master' into xsight-platform-dev
deran1980 Feb 15, 2024
a9b8721
arrange order of ssd types after resolving merge conflict
deran1980 Feb 15, 2024
16d5020
add test coverage for wdc ssd
deran1980 Feb 15, 2024
0e67cd7
fix assert in test case
deran1980 Feb 15, 2024
8e8188f
fix test case, change string to int
deran1980 Feb 15, 2024
67952e2
fix test - get temperature
deran1980 Feb 15, 2024
d0c5771
Merge branch 'master' into xsight-platform-dev
prgeor Feb 27, 2024
40e7c3f
Merge branch 'master' into xsight-platform-dev
deran1980 Mar 12, 2024
8c08961
change temprature regex to return scalar value only
deran1980 May 2, 2024
c34b826
Merge branch 'xsight-platform-dev' of github.com:deran1980/sonic-plat…
deran1980 May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion sonic_platform_base/sonic_ssd/ssd_generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ def __init__(self, diskdev):
"M.2" : { "utility" : INNODISK, "parser" : self.parse_innodisk_info },
"StorFly" : { "utility" : VIRTIUM, "parser" : self.parse_virtium_info },
"Virtium" : { "utility" : VIRTIUM, "parser" : self.parse_virtium_info },
"Swissbit" : { "utility" : SMARTCTL, "parser" : self.parse_swissbit_info },
"WDC" : { "utility" : SMARTCTL, "parser" : self.parse_wdc_ssd_info },
"Swissbit" : { "utility" : SMARTCTL, "parser" : self.parse_swissbit_info }
}

self.dev = diskdev
Expand Down Expand Up @@ -125,6 +126,21 @@ def parse_generic_ssd_info(self):
self.serial = self._parse_re('Serial Number:\s*(.+?)\n', self.ssd_info)
self.firmware = self._parse_re('Firmware Version:\s*(.+?)\n', self.ssd_info)

def parse_wdc_ssd_info(self):
self.model = self._parse_re('Device Model:\s*(.+?)\n', self.ssd_info)
self.serial = self._parse_re('Serial Number:\s*(.+?)\n', self.ssd_info)
self.firmware = self._parse_re('Firmware Version:\s*(.+?)\n', self.ssd_info)
try:
if ("SDASN8Y1T00" == self.model.split(' ')[3]):
self.nand_endurance = 400 * 1000
Copy link
Contributor

@ashwnsri ashwnsri Dec 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @deran1980 - could you please elaborate on why NAND endurance is set to this value?

Copy link
Contributor

@ashwnsri ashwnsri Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deran1980

parsed_total_lbas_written = self._parse_re('Total_LBAs_Written\s*.*Offline\s*-\s*\d*', self.vendor_ssd_info)
total_lbas_written = int(self._parse_re('\s{7}\d*', parsed_total_lbas_written).split(' ')[7])
self.health = int(100.0 - (total_lbas_written * 100) / self.nand_endurance)
celsius_str = self._parse_re('Temperature_Celsius\s*.*', self.vendor_ssd_info)
self.temperature = self._parse_re('\d*\s\(Min.*', celsius_str)
except (ValueError, IndexError):
pass

def parse_innodisk_info(self):
if self.vendor_ssd_info:
self.health = self._parse_re('Health:\s*(.+?)%', self.vendor_ssd_info)
Expand Down