[cmis] Optimize cmis.get_error_description speed for passive module#526
Merged
prgeor merged 1 commit intosonic-net:masterfrom Jan 28, 2025
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
aacda6b to
8eb3462
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
keboliu
approved these changes
Jan 2, 2025
mihirpat1
approved these changes
Jan 2, 2025
prgeor
approved these changes
Jan 28, 2025
Collaborator
|
Cherry-pick PR to 202405: #541 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
cmis.get_error_description is very slow for passive module:
For a module that has flat memory, it does not need check data path state. Because of this issue,
show error-status --fetch-from-hardwaretakes very long time if there are many passive modules present:After the fix, it changes to:
Motivation and Context
Optimize cmis.get_error_description for passive module
How Has This Been Tested?
Manual test
Unit test
Additional Information (Optional)