Adding is_copper api to cmis #547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@bobbymcgonigle will review once out of draft |
Contributor
Author
Thanks Prince, this PR is ready for review |
prgeor
approved these changes
Mar 9, 2025
mihirpat1
added
Request for msft-202412 Branch
and removed
Request for msft-202412 Branch
labels
|
Can we port this to msft-202503? Thanks! |
ravil-nexthop
pushed a commit
to ravil-nexthop/sonic-platform-common
that referenced
this pull request
May 21, 2025
(cherry picked from commit 45b10be)
ravil-nexthop
pushed a commit
to ravil-nexthop/sonic-platform-common
that referenced
this pull request
Jul 1, 2025
(cherry picked from commit 45b10be)
prgeor
pushed a commit
that referenced
this pull request
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For CMISwe can tell if a module is copper because the media interface will always be passive_copper_media_interface. This PR adds a check for that.
Motivation and Context
Similar to other SFF xcvr api's it would be helpful to know if a CMIS module is copper or optical. We can use this information for tunings and in other areas where appropriate.
How Has This Been Tested?
Wrote a unit test and tested manually on device using multiple optics and DACs
Additional Information (Optional)