[action] [PR:611] [cmis] Only create CdbFwHandler if module support CDB #619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Provide a general summary of your changes in the Title above -->
#### Description
CdbFwHandler is created to handle CDB related command for cmis module. It should be created only CDB is supported by this module. However, the current implementation add an assertion in __init__ function which will fail any cmis module which does not support CDB:
```
class CdbFwHandler(CdbCmdHandler):
def __init__(self, reader, writer, mem_map):
super(CdbFwHandler, self).__init__(reader, writer, mem_map)
self.start_payload_size = 0
self.is_lpl_only = False
self.rw_length_ext = 0
assert True == self.initFwHandler(), "Failed to initialize firmware handler"
```
The error logs:
```
2025 Nov 16 12:21:21.010105 sonic INFO pmon#supervisord: xcvrd Error creating API: Failed to initialize firmware handler
2025 Nov 16 12:21:21.010182 sonic INFO pmon#supervisord: xcvrd Failed to get firmware management features
```
#### Motivation and Context
Only create CdbFwHandler if module support CDB
#### How Has This Been Tested?
<!--
Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.
-->
Manual test with modules that support and not support CDB
Unit test
#### Additional Information (Optional)
Collaborator
Author
|
Original PR: #611 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CdbFwHandler is created to handle CDB related command for cmis module. It should be created only CDB is supported by this module. However, the current implementation add an assertion in init function which will fail any cmis module which does not support CDB:
The error logs:
Motivation and Context
Only create CdbFwHandler if module support CDB
How Has This Been Tested?
Manual test with modules that support and not support CDB
Unit test
Additional Information (Optional)