Skip to content

[action] [PR:1674] Add PORT_PHY_ATTR flex counter support#1776

Open
mssonicbld wants to merge 2 commits intosonic-net:202511from
mssonicbld:cherry/202511/1674
Open

[action] [PR:1674] Add PORT_PHY_ATTR flex counter support#1776
mssonicbld wants to merge 2 commits intosonic-net:202511from
mssonicbld:cherry/202511/1674

Conversation

@mssonicbld
Copy link
Collaborator

Implement PORT_PHY_ATTR flex counter support for monitoring the port attributes (RX_SIGNAL_DETECT, FEC_ALIGNMENT_LOCK, RX_SNR).

Changes

meta/: Add serialization support for PORT_SNR_LIST and PORT_LANE_LATCH_STATUS_LIST
syncd/: Introduce PortAttrContext extending AttrContext with specialized data handling for lane-based attribute types
unittest/: Add unit tests for serialization and collectData APIs.

Implementation

Queries SAI for per-port lane count using BUFFER_OVERFLOW pattern
Maintains lane count cache for efficient memory allocation
Writes collected data to dedicated PORT_PHY_ATTR table in COUNTERS_DB

Implement PORT_PHY_ATTR flex counter support for monitoring the port attributes (RX_SIGNAL_DETECT, FEC_ALIGNMENT_LOCK, RX_SNR).

### Changes
**meta/:** Add serialization support for PORT_SNR_LIST and PORT_LANE_LATCH_STATUS_LIST
**syncd/:** Introduce PortAttrContext extending AttrContext with specialized data handling for lane-based attribute types
**unittest/:** Add unit tests for serialization and collectData APIs.

### Implementation
Queries SAI for per-port lane count using BUFFER_OVERFLOW pattern
Maintains lane count cache for efficient memory allocation
Writes collected data to dedicated PORT_PHY_ATTR table in COUNTERS_DB
@mssonicbld
Copy link
Collaborator Author

Original PR: #1674

@mssonicbld
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dhanasekar-arista
Copy link
Contributor

The PR checks need to be retriggered and run on latest code after merge of this commit sonic-net/sonic-swss-common@79b6b11
@prgeor can you please trigger them.

@saiarcot895
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dhanasekar-arista
Copy link
Contributor

Azure.sonic-sairedis (BuildAsan amd64)Failing after 24m — BuildAsan amd64 failed
The failure is unrelated to the change and DCO action is not required because this is a cherry-pick PR automatically created.

FYI, i've created a dummy PR(with same set of changes) to ensure all checks are passing. refer #1785

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants