Skip to content

Conversation

@VladimirKuk
Copy link

Added support for local ARS (Adaptive Routing and Switching).

HLD: sonic-net/SONiC#1958

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

common/schema.h Outdated
#define PLUGIN_TABLE "PLUGIN_TABLE"
#define LUA_PLUGIN_TYPE "LUA_PLUGIN_TYPE"
#define SAI_OBJECT_TYPE "SAI_OBJECT_TYPE"
#define PFC_WD_POLL_MSECS 100
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the changes not applicable to this feature

common/schema.h Outdated
#define BMP_STATE_BGP_RIB_IN_TABLE "BGP_RIB_IN_TABLE"
#define BMP_STATE_BGP_RIB_OUT_TABLE "BGP_RIB_OUT_TABLE"

/* ARS */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to move to lint602 with other state db table names.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed it

common/schema.h Outdated

#define CFG_ARS_PROFILE "ARS_PROFILE"
#define CFG_ARS_INTERFACE "ARS_INTERFACE"
#define CFG_ARS_NEXTHOP_GROUP "ARS_NEXTHOP_GROUP"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz check the latest changes.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CFG_ macros are auto-generated from YANG models via cfg_schema.h. hence, this changes are removed from schema.h

Signed-off-by: Vladimir Kuk <[email protected]>
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

#define APP_SWITCH_TABLE_NAME "SWITCH_TABLE"
#define APP_NEXTHOP_GROUP_TABLE_NAME "NEXTHOP_GROUP_TABLE"
#define APP_CLASS_BASED_NEXT_HOP_GROUP_TABLE_NAME "CLASS_BASED_NEXT_HOP_GROUP_TABLE"
#define APP_EVPN_SPLIT_HORIZON_TABLE_NAME "EVPN_SPLIT_HORIZON_TABLE"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove existing definition?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of a merge conflict the file was removed, and i have restored it now.

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Vladimir Kuk <[email protected]>
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@apannerselva
Copy link

/azpw run Azure.sonic-swss-common (Test vstest)

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss-common (Test vstest)

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants