Add DEBUG_DROP_MONITOR table to schema.h #971

arista-hpandya · 2025-02-10T19:18:32Z

What I did

Added the DEBUG_DROP_MONITOR table definition to sonic-swss-common.

Why I did it

This change is a prerequisite for another PR (sonic-net/sonic-swss#3509) that relies on using the DEBUG_DROP_MONITOR table in the orchagent for persistent drop counter monitoring.

How I verified it
NA

Details if related

This PR only adds the table definition. The logic to read, process, and act upon the data in this table is implemented in a PR linked above.

Fixes #972
HLD: sonic-net/SONiC#1912

mssonicbld · 2025-02-10T19:18:35Z

/azp run

azure-pipelines · 2025-02-10T19:18:47Z

Azure Pipelines successfully started running 1 pipeline(s).

FengPan-Frank

LGTM

mssonicbld · 2025-05-15T18:36:55Z

/azp run

azure-pipelines · 2025-05-15T18:37:10Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-05-24T10:39:19Z

/azp run

azure-pipelines · 2025-05-24T10:39:29Z

Azure Pipelines successfully started running 1 pipeline(s).

arista-hpandya · 2025-05-26T17:18:55Z

/azpw run Azure.sonic-swss

mssonicbld · 2025-05-26T17:18:57Z

/AzurePipelines run Azure.sonic-swss

azure-pipelines · 2025-05-26T17:19:03Z

No pipelines are associated with this pull request.

vmittal-msft · 2025-06-17T20:38:27Z

@arista-hpandya please rebase.

mssonicbld · 2025-06-17T20:57:26Z

/azp run

azure-pipelines · 2025-06-17T20:57:38Z

Azure Pipelines successfully started running 1 pipeline(s).

arista-hpandya · 2025-06-18T17:30:39Z

The vstest failure is unrelated to the change, can we override the warnings and go ahead with the merge?

dash/test_dash_acl.py: 12 warnings
  /usr/local/lib/python3.10/dist-packages/_pytest/unraisableexception.py:65: PytestUnraisableExceptionWarning: Exception ignored in: <function ApplDbValidator.__del__ at 0x75b5f2665a20>
  
  Traceback (most recent call last):
    File "/agent/_work/1/s/sonic-swss/tests/conftest.py", line 184, in __del__
      neighbors = self.get_keys(self.NEIGH_TABLE)
    File "/agent/_work/1/s/sonic-swss/tests/dvslib/dvs_database.py", line 134, in get_keys
      table = swsscommon.Table(self.db_connection, table_name)
    File "/usr/lib/python3/dist-packages/swsscommon/swsscommon.py", line 3169, in __init__
      _swsscommon.Table_swiginit(self, _swsscommon.new_Table(*args))
  RuntimeError: Unable to connect to redis (unix-socket) - No such file or directory(1): Cannot assign requested address
  
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.
    warnings.warn(pytest.PytestUnraisableExceptionWarning(msg))

vmittal-msft · 2025-06-24T17:45:57Z

Please rebase and re-run pipeline.

mssonicbld · 2025-06-25T16:47:06Z

/azp run

azure-pipelines · 2025-06-25T16:47:19Z

Azure Pipelines successfully started running 1 pipeline(s).

arista-hpandya · 2025-07-03T22:53:34Z

The failures are because of an outdated libyang version:

libyang-dev depends on libyang3 (= 3.12.2-1); however:
Package libyang3 is not installed.

Enhancement to libyang3 is being tracked here: sonic-net/sonic-buildimage#22385

Since this particular change is harmless and irrelevant to the failure could we merge this in? This is a dependency of sonic-net/sonic-swss#3509 and its waiting on this being merged.

cc: @vmittal-msft

azure-pipelines · 2025-08-06T20:52:53Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-08-07T16:26:57Z

/azp run

azure-pipelines · 2025-08-07T16:27:09Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-08-12T04:47:07Z

/azp run

azure-pipelines · 2025-08-12T04:47:19Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-08-13T16:37:50Z

/azp run

azure-pipelines · 2025-08-13T16:38:03Z

Azure Pipelines successfully started running 1 pipeline(s).

vmittal-msft · 2025-08-14T16:29:10Z

@arista-hpandya please resolve conflicts.

mssonicbld · 2025-08-25T22:14:31Z

/azp run

azure-pipelines · 2025-08-25T22:14:42Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-08-27T16:03:56Z

/azp run

azure-pipelines · 2025-08-27T16:04:09Z

Azure Pipelines successfully started running 1 pipeline(s).

arista-hpandya · 2025-08-27T16:06:30Z

@vmittal-msft the semgrep needs maintainer approval without which it gets stuck, all tests have passed and this can be merged:

vmittal-msft · 2025-08-27T18:51:37Z

@rlhui @yxieca please help merge.

arista-hpandya · 2025-08-27T20:02:44Z

@vmittal-msft @rlhui @yxieca All tests have passed could we merge this please, thanks!

…onitoring feature (#3509) * Add support for configurable debug drop monitoring feature Note: This change depends on sonic-net/sonic-swss-common#971 Fixes #3501 HLD: sonic-net/SONiC#1912 What I did Added logic to read configuration from the DEBUG_DROP_MONITOR table. Added logic to register persistent alerts when the conditions are met. Added logic to toggle the feature off if desired on a per-counter level. Why I did it To implement the persistent drop counter monitoring feature which allows users to configure thresholds for drop counters and register alerts when persistent drops are detected. How I verified it Existing unit tests were run using make check to ensure no functionality was affected. New unit tests have been added to verify the functionality. Manual testing was performed on a SONiC switch to verify that the orchagent correctly reads the configuration, generates alerts when thresholds are met, and can be toggled off/on.

…onitoring feature (sonic-net#3509) * Add support for configurable debug drop monitoring feature Note: This change depends on sonic-net/sonic-swss-common#971 Fixes sonic-net#3501 HLD: sonic-net/SONiC#1912 What I did Added logic to read configuration from the DEBUG_DROP_MONITOR table. Added logic to register persistent alerts when the conditions are met. Added logic to toggle the feature off if desired on a per-counter level. Why I did it To implement the persistent drop counter monitoring feature which allows users to configure thresholds for drop counters and register alerts when persistent drops are detected. How I verified it Existing unit tests were run using make check to ensure no functionality was affected. New unit tests have been added to verify the functionality. Manual testing was performed on a SONiC switch to verify that the orchagent correctly reads the configuration, generates alerts when thresholds are met, and can be toggled off/on.

Add DEBUG_DROP_MONITOR table to schema.h

5aff60b

This was referenced Feb 10, 2025

[Feature] Add DEBUG_DROP_MONITOR table in schema.h #972

Closed

[Feature][debugcounterorch] Add support for configurable debug drop monitoring feature sonic-net/sonic-swss#3509

Merged

Internal drop counter monitoring sonic-net/SONiC#1542

Closed

FengPan-Frank previously approved these changes Feb 12, 2025

View reviewed changes

arista-hpandya marked this pull request as draft February 18, 2025 17:41

Merge branch 'master' into add-debug-drop-monitor-table

88d6ccf

arista-hpandya marked this pull request as ready for review May 15, 2025 18:36

Merge branch 'master' into add-debug-drop-monitor-table

b6595a4

vmittal-msft previously approved these changes Jun 17, 2025

View reviewed changes

Merge branch 'master' into add-debug-drop-monitor-table

4c4695f

Merge branch 'master' into add-debug-drop-monitor-table

4a00283

Merge branch 'master' into add-debug-drop-monitor-table

9bf1ce4

Merge branch 'master' into add-debug-drop-monitor-table

88f8e73

Merge branch 'master' into add-debug-drop-monitor-table

6f6a47c

arista-hpandya dismissed stale reviews from vmittal-msft and FengPan-Frank via 6f6a47c August 12, 2025 04:47

Merge branch 'master' into add-debug-drop-monitor-table

629fba2

arista-hpandya mentioned this pull request Aug 13, 2025

HLD document for configurable drop counter monitoring sonic-net/SONiC#1912

Merged

vmittal-msft self-assigned this Aug 14, 2025

Merge branch 'master' into add-debug-drop-monitor-table

6353967

Merge branch 'master' into add-debug-drop-monitor-table

2c21d56

rlhui approved these changes Aug 27, 2025

View reviewed changes

rlhui merged commit f0e88e0 into sonic-net:master Aug 27, 2025
15 checks passed

github-project-automation bot moved this to Done in SONiC Chassis Aug 27, 2025

Add DEBUG_DROP_MONITOR table to schema.h #971

Add DEBUG_DROP_MONITOR table to schema.h #971

Uh oh!

Conversation

arista-hpandya commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mssonicbld commented Feb 10, 2025

Uh oh!

azure-pipelines bot commented Feb 10, 2025

Uh oh!

FengPan-Frank left a comment

Choose a reason for hiding this comment

Uh oh!

mssonicbld commented May 15, 2025

Uh oh!

azure-pipelines bot commented May 15, 2025

Uh oh!

mssonicbld commented May 24, 2025

Uh oh!

azure-pipelines bot commented May 24, 2025

Uh oh!

arista-hpandya commented May 26, 2025

Uh oh!

mssonicbld commented May 26, 2025

Uh oh!

azure-pipelines bot commented May 26, 2025

Uh oh!

vmittal-msft commented Jun 17, 2025

Uh oh!

mssonicbld commented Jun 17, 2025

Uh oh!

azure-pipelines bot commented Jun 17, 2025

Uh oh!

arista-hpandya commented Jun 18, 2025

Uh oh!

vmittal-msft commented Jun 24, 2025

Uh oh!

mssonicbld commented Jun 25, 2025

Uh oh!

azure-pipelines bot commented Jun 25, 2025

Uh oh!

arista-hpandya commented Jul 3, 2025

Uh oh!

azure-pipelines bot commented Aug 6, 2025

Uh oh!

mssonicbld commented Aug 7, 2025

Uh oh!

azure-pipelines bot commented Aug 7, 2025

Uh oh!

mssonicbld commented Aug 12, 2025

Uh oh!

azure-pipelines bot commented Aug 12, 2025

Uh oh!

mssonicbld commented Aug 13, 2025

Uh oh!

azure-pipelines bot commented Aug 13, 2025

Uh oh!

vmittal-msft commented Aug 14, 2025

Uh oh!

mssonicbld commented Aug 25, 2025

Uh oh!

azure-pipelines bot commented Aug 25, 2025

Uh oh!

mssonicbld commented Aug 27, 2025

Uh oh!

azure-pipelines bot commented Aug 27, 2025

Uh oh!

arista-hpandya commented Aug 27, 2025

Uh oh!

vmittal-msft commented Aug 27, 2025

Uh oh!

arista-hpandya commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

arista-hpandya commented Feb 10, 2025 •

edited

Loading

arista-hpandya commented Aug 27, 2025 •

edited

Loading