[DPB]: Fix stale queue counter maps in COUNTERS_DB after port breakout #3982

rminnikanti · 2025-11-09T10:15:13Z

What I did
Added cleanup of COUNTERS_*_NAME_MAP entries for a port during its deinit phase, and regenerated the NAME_MAP tables with fresh OIDs during port init when queue flex counters are already enabled.

Why I did it
After dynamic port breakout of a port, queue name map tables in the COUNTERS_DB table are not regenerated leaving stale entries resulting in CLI crash

How I verified it

# show queue counters Ethernet0
For namespace :
     Port    TxQ    Counter/pkts    Counter/bytes    Drop/pkts    Drop/bytes
---------  -----  --------------  ---------------  -----------  ------------
Ethernet0    UC0               0                0            0             0
Ethernet0    UC1               0                0            0             0
Ethernet0    UC2               0                0            0             0
Ethernet0    UC3               0                0            0             0
Ethernet0    UC4               0                0            0             0
Ethernet0    UC5               0                0            0             0
Ethernet0    UC6               0                0            0             0
Ethernet0    UC7               0                0            0             0

root@sonic:~# redis-dump -d 2 -k "COUNTERS_PORT_NAME_MAP*" | jq | grep Ethernet448
      "Ethernet448": "oid:0x100000000085c",
root@sonic:~#  redis-dump -d 2 -k "COUNTERS_QUEUE_PORT_MAP*" | jq | grep 0x100000000085c
      "oid:0x15000000000860": "oid:0x100000000085c",
      "oid:0x15000000000861": "oid:0x100000000085c",
      "oid:0x15000000000862": "oid:0x100000000085c",
      "oid:0x15000000000863": "oid:0x100000000085c",
      "oid:0x15000000000864": "oid:0x100000000085c",
      "oid:0x1500000000085d": "oid:0x100000000085c",
      "oid:0x1500000000085f": "oid:0x100000000085c",
      "oid:0x1500000000085e": "oid:0x100000000085c",
root@sonic:~# redis-dump -d 2 -k "COUNTERS_QUEUE_NAME_MAP*" | jq | grep -E "0x15000000000860|0x15000000000861|0x15000000000862|0x15000000000863|0x15000000000864|0x1500000000085d|0x1500000000085f|0x1500000000085e"
      "Ethernet448:6": "oid:0x15000000000863",
      "Ethernet448:2": "oid:0x1500000000085f",
      "Ethernet448:4": "oid:0x15000000000861",
      "Ethernet448:7": "oid:0x15000000000864",
      "Ethernet448:3": "oid:0x15000000000860",
      "Ethernet448:0": "oid:0x1500000000085d",
      "Ethernet448:5": "oid:0x15000000000862",
      "Ethernet448:1": "oid:0x1500000000085e",
root@sonic:~# redis-dump -d 2 -k "COUNTERS_QUEUE_INDEX_MAP*" | jq | grep -E "0x15000000000860|0x15000000000861|0x15000000000862|0x15000000000863|0x15000000000864|0x1500000000085d|0x1500000000085f|0x1500000000085e"
      "oid:0x15000000000860": "3",
      "oid:0x15000000000861": "4",
      "oid:0x15000000000862": "5",
      "oid:0x15000000000863": "6",
      "oid:0x15000000000864": "7",
      "oid:0x1500000000085d": "0",
      "oid:0x1500000000085f": "2",
      "oid:0x1500000000085e": "1",
root@sonic:~#  redis-dump -d 2 -k "COUNTERS_QUEUE_TYPE_MAP*" | jq | grep -E "0x15000000000860|0x15000000000861|0x15000000000862|0x15000000000863|0x15000000000864|0x1500000000085d|0x1500000000085f|0x1500000000085e"
      "oid:0x15000000000860": "SAI_QUEUE_TYPE_UNICAST",
      "oid:0x15000000000861": "SAI_QUEUE_TYPE_UNICAST",
      "oid:0x15000000000862": "SAI_QUEUE_TYPE_UNICAST",
      "oid:0x15000000000863": "SAI_QUEUE_TYPE_UNICAST",
      "oid:0x15000000000864": "SAI_QUEUE_TYPE_UNICAST",
      "oid:0x1500000000085d": "SAI_QUEUE_TYPE_UNICAST",
      "oid:0x1500000000085f": "SAI_QUEUE_TYPE_UNICAST",
      "oid:0x1500000000085e": "SAI_QUEUE_TYPE_UNICAST",

Details if related

…kout Fix cleans up COUNTERS_*_NAME_MAP of the port during deinit of the port and regenerate the NAME_MAP's with new OID's during port init if queue flex counters are already enabled. Signed-off-by: Ravi Minnikanti <[email protected]>

mssonicbld · 2025-11-09T10:15:21Z

/azp run

azure-pipelines · 2025-11-09T10:15:30Z

Azure Pipelines successfully started running 1 pipeline(s).

rminnikanti · 2025-11-09T14:45:59Z

orchagent/high_frequency_telemetry/counternameupdater.cpp

 {
    SWSS_LOG_ENTER();

-    if (gHFTOrch)


@Pterosaur can you please review?

mssonicbld · 2025-11-09T14:46:56Z

/azp run

azure-pipelines · 2025-11-09T14:47:05Z

Azure Pipelines successfully started running 1 pipeline(s).

Pterosaur

@kperumalbfn Could you please help to review this PR?
If we merge this PR, I will close my PR: #3967 that is duplicated.

kperumalbfn · 2025-11-10T18:20:33Z

orchagent/portsorch.cpp

+    bool queueFcEnabled = flex_counters_orch->getQueueCountersState() ||
+                            flex_counters_orch->getQueueWatermarkCountersState() ||
+                            flex_counters_orch->getWredQueueCountersState();
+    if (queueFcEnabled && !p.m_queue_ids.empty())


@rminnikanti could you please check the DPB sonic-mgmt tests? If this is not covered, could you please add them?

@kperumalbfn I don't see DPB test component in PTF. As far as I understand, DPB testing in sonic-mgmt can be performed on ports that are not part of the topology.

The mock_tests included in this PR verifies the regeneration of the NAME_MAP's. I’ve also validated this behavior on a device and shared the redis-dump output in the PR description for reference.

kperumalbfn

@Pterosaur could you close the PR - #3967

mssonicbld · 2025-11-11T22:26:09Z

/azp run

azure-pipelines · 2025-11-11T22:26:19Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-11-13T01:59:07Z

/azp run

azure-pipelines · 2025-11-13T01:59:20Z

Azure Pipelines successfully started running 1 pipeline(s).

StormLiangMS · 2025-11-13T06:09:54Z

/azp run Azure.sonic-swss

azure-pipelines · 2025-11-13T06:10:04Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-11-16T06:43:39Z

/azp run

azure-pipelines · 2025-11-16T06:43:49Z

Azure Pipelines successfully started running 1 pipeline(s).

sdszhang · 2025-11-19T07:22:08Z

@rminnikanti can you create a cherry-pick PR to msft-202412

rminnikanti · 2025-11-19T12:14:53Z

@rminnikanti can you create a cherry-pick PR to msft-202412

@sdszhang created PR - Azure/sonic-swss.msft#170

Signed-off-by: Ravi Minnikanti <[email protected]>

mssonicbld · 2025-11-25T09:42:30Z

/azp run

azure-pipelines · 2025-11-25T09:42:40Z

Azure Pipelines successfully started running 1 pipeline(s).

rminnikanti · 2025-11-25T13:23:15Z

@r12f @ZhaohuiS Fixed. PR checks passed.

@r12f I have propagated fix to Azure/sonic-swss.msft#170

mssonicbld · 2025-11-28T05:31:11Z

Cherry-pick PR to msft-202412:

r12f · 2025-12-02T06:04:55Z

Hi @rminnikanti , we are hitting test failure on 202412 due to the PR being incorrectly ported, do you mind to help us look into it?

@kperumalbfn for viz.

rminnikanti · 2025-12-02T06:11:23Z

Hi @rminnikanti , we are hitting test failure on 202412 due to the PR being incorrectly ported, do you mind to help us look into it?

@kperumalbfn for viz.

@r12f I identified the fix. Its not exactly because of the cherry-picked PR but because of a missing mock_table function in 202412. I will fix it soon.

r12f · 2025-12-02T06:13:28Z

Thanks a lot Ravi!

rminnikanti · 2025-12-02T06:30:52Z

Thanks a lot Ravi!

Created Azure/sonic-swss.msft#175

sonic-net#3982) What I did Added cleanup of COUNTERS_*_NAME_MAP entries for a port during its deinit phase, and regenerated the NAME_MAP tables with fresh OIDs during port init when queue flex counters are already enabled. Why I did it After dynamic port breakout of a port, queue name map tables in the COUNTERS_DB table are not regenerated leaving stale entries resulting in CLI crash Signed-off-by: Kalash Nainwal <[email protected]>

govi-nokia · 2025-12-23T15:08:46Z

@prsunny Could this fix be taken to 202511 please? Please add the appropriate labels for the same.

@Pavan-Nokia viz
@balanokia viz
@dgodwin-nokia viz

sonic-net#3982) What I did Added cleanup of COUNTERS_*_NAME_MAP entries for a port during its deinit phase, and regenerated the NAME_MAP tables with fresh OIDs during port init when queue flex counters are already enabled. Why I did it After dynamic port breakout of a port, queue name map tables in the COUNTERS_DB table are not regenerated leaving stale entries resulting in CLI crash

mssonicbld · 2026-01-06T17:32:42Z

Cherry-pick PR to 202511: #4109

PR:sonic-net/sonic-swss#3982 Also, added missing mock test function from master identified in: Azure#175 Signed-off-by: Dakota Crozier <[email protected]>

dakotac-arista · 2026-01-20T19:37:25Z

Hi @prsunny, can the fix be backported to msft-202503 as well? PR: Azure/sonic-swss.msft#196

…ost port breakout (#196) PR: sonic-net/sonic-swss#3982 Also, included missing mock test function from master. As identified in msft-202412: #175 Signed-off-by: Dakota Crozier <[email protected]>

rminnikanti requested a review from prsunny as a code owner November 9, 2025 10:15

rminnikanti commented Nov 9, 2025

View reviewed changes

Merge branch 'master' into dpb_queue_fix

4120053

Pterosaur approved these changes Nov 10, 2025

View reviewed changes

kperumalbfn reviewed Nov 10, 2025

View reviewed changes

Pterosaur mentioned this pull request Nov 10, 2025

[hft]: Fix queue and ipg stats missing if hft isn't supported #3967

Closed

Pterosaur added Request for msft-202412 Branch Approved for msft-202412 Branch labels Nov 10, 2025

mssonicbld added Cherry Pick Conflict_msft-202412 labels Nov 10, 2025

kperumalbfn previously approved these changes Nov 11, 2025

View reviewed changes

Merge branch 'master' into dpb_queue_fix

d8f887c

Merge branch 'master' into dpb_queue_fix

11cd188

Merge branch 'master' into dpb_queue_fix

d48a81f

Fix m_host_tx_queue condition check

444b0d1

Signed-off-by: Ravi Minnikanti <[email protected]>

rminnikanti dismissed kperumalbfn’s stale review via 444b0d1 November 25, 2025 09:42

prsunny merged commit 4d39712 into sonic-net:master Nov 28, 2025
15 checks passed

mssonicbld added the Created PR to msft-202412 Branch label Nov 28, 2025

r12f added Included in msft-202412 Branch and removed Cherry Pick Conflict_msft-202412 Created PR to msft-202412 Branch labels Dec 9, 2025

prsunny added Request for 202511 Branch Approved for 202511 Branch labels Jan 6, 2026

mssonicbld mentioned this pull request Jan 6, 2026

[action] [PR:3982] [DPB]: Fix stale queue counter maps in COUNTERS_DB after port breakout #4109

Merged

mssonicbld added the Created PR to 202511 Branch label Jan 6, 2026

dakotac-arista mentioned this pull request Jan 20, 2026

[202503] [Backport] Fix Stale queue counter mappings in COUNTERS_DB post port breakout Azure/sonic-swss.msft#196

Merged

mssonicbld added Included in 202511 Branch and removed Created PR to 202511 Branch labels Jan 22, 2026

tjchadaga mentioned this pull request Jan 28, 2026

Bug: show queue counters returns no output on DNX platforms sonic-net/sonic-buildimage#25216

Open

[DPB]: Fix stale queue counter maps in COUNTERS_DB after port breakout #3982

[DPB]: Fix stale queue counter maps in COUNTERS_DB after port breakout #3982

Conversation

rminnikanti commented Nov 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mssonicbld commented Nov 9, 2025

Uh oh!

azure-pipelines bot commented Nov 9, 2025

Uh oh!

rminnikanti Nov 9, 2025

Choose a reason for hiding this comment

Uh oh!

mssonicbld commented Nov 9, 2025

Uh oh!

azure-pipelines bot commented Nov 9, 2025

Uh oh!

Pterosaur left a comment

Choose a reason for hiding this comment

Uh oh!

kperumalbfn Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

rminnikanti Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

kperumalbfn left a comment

Choose a reason for hiding this comment

Uh oh!

mssonicbld commented Nov 11, 2025

Uh oh!

azure-pipelines bot commented Nov 11, 2025

Uh oh!

mssonicbld commented Nov 13, 2025

Uh oh!

azure-pipelines bot commented Nov 13, 2025

Uh oh!

StormLiangMS commented Nov 13, 2025

Uh oh!

azure-pipelines bot commented Nov 13, 2025

Uh oh!

mssonicbld commented Nov 16, 2025

Uh oh!

azure-pipelines bot commented Nov 16, 2025

Uh oh!

sdszhang commented Nov 19, 2025

Uh oh!

rminnikanti commented Nov 19, 2025

Uh oh!

mssonicbld commented Nov 25, 2025

Uh oh!

azure-pipelines bot commented Nov 25, 2025

Uh oh!

rminnikanti commented Nov 25, 2025

Uh oh!

Uh oh!

mssonicbld commented Nov 28, 2025

Uh oh!

r12f commented Dec 2, 2025

Uh oh!

rminnikanti commented Dec 2, 2025

Uh oh!

r12f commented Dec 2, 2025

Uh oh!

rminnikanti commented Dec 2, 2025

Uh oh!

govi-nokia commented Dec 23, 2025

Uh oh!

mssonicbld commented Jan 6, 2026

Uh oh!

dakotac-arista commented Jan 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

rminnikanti commented Nov 9, 2025 •

edited

Loading