-
Notifications
You must be signed in to change notification settings - Fork 753
Added support for TLV_CODE_VENDOR_NAME #3765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hey @FengPan-Frank , please help review |
|
@yaqiangz Appreciate your help in reviewing this PR. |
could you fix the coverage? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Hi Frank, added test coverage. Thanks! |
FengPan-Frank
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks Frank! Could you please help approve the required PRs as well: |
What I did
Required PRs:
sonic-net/sonic-platform-common#542
sonic-net/sonic-buildimage#21722
Logs: