Fix namespace typo in portconfig and related files #4156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Bojun-Feng
force-pushed
the
namespace-typo
branch
from
0064bdd to
b69bf08
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
What I did - corrected `namesapce` -> `namespace` across portconfig/docs/tests. Signed-off-by: Bojun Feng <bojundf@gmail.com>
Bojun-Feng
force-pushed
the
namespace-typo
branch
from
b69bf08 to
d09a13c
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Re-pushed commit to update deprecated email |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix sonic-net/sonic-buildimage#24836
Fix #2795
Corrected
namesapce->namespaceacross portconfig/docs/tests.This prevents the
scripts/portconfigscript from crashing due to this line:sonic-utilities/scripts/portconfig
Line 259 in d17d124
How I did it
Updated the
SonicV2Connectorinitialization that referenced the wrong argument name, also did key word find-and-replace on the documentation.How to verify it
The code change here should be self-explanatory.
Previous command output (if the output of a command-line utility has changed)
N/A
New command output (if the output of a command-line utility has changed)
N/A