[Fast-linkup] Added CLIs for config/show #4182

YairRaviv · 2026-01-07T10:29:31Z

HLD: fast-link-up-hld.md

What I did

Implemented CLI for Fast-linkup feature including:

config feature parameters
enable/disable the feature per-port
show feature parameters
show interfaces feature status

How I did it

By adding the new command support to config and show CLI

How to verify it

Run Fast-linkup CLIs

Which release branch to backport (provide reason below if selected)

202511

New command output (if the output of a command-line utility has changed)

admin@sonic:/home/admin# show switch-fast-linkup global
+---------------+---------+
| Field         |   Value |
+===============+=========+
| ber_threshold |      10 |
+---------------+---------+
| guard_time    |      15 |
+---------------+---------+
| polling_time  |      60 |
+---------------+---------+

admin@sonic:/home/admin# show interfaces fast-linkup status
+-------------+---------------+
| Interface   | fast_linkup   |
+=============+===============+
| Ethernet0   | true          |
| Ethernet4   | true          |
| Ethernet8   | true          |
| Ethernet12  | false         |
| Ethernet16  | false         |
| Ethernet20  | false         |
| Ethernet24  | false         |
| Ethernet28  | false         |
| Ethernet32  | false         |
| Ethernet36  | false         |
| Ethernet40  | false         |
| Ethernet44  | false         |
| Ethernet48  | false         |
| Ethernet52  | false         |
| Ethernet56  | false         |
| Ethernet60  | false         |
| Ethernet64  | false         |
| Ethernet68  | false         |
| Ethernet72  | false         |
| Ethernet76  | false         |
| Ethernet80  | false         |
| Ethernet84  | false         |
| Ethernet88  | false         |
| Ethernet92  | false         |
| Ethernet96  | false         |
| Ethernet100 | false         |
| Ethernet104 | false         |
| Ethernet108 | false         |
| Ethernet112 | false         |
| Ethernet116 | false         |
| Ethernet120 | false         |
| Ethernet124 | false         |
+-------------+---------------+

mssonicbld · 2026-01-07T10:29:38Z

/azp run

azure-pipelines · 2026-01-07T10:29:49Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-01-07T12:04:50Z

/azp run

azure-pipelines · 2026-01-07T12:05:00Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-01-07T12:07:18Z

/azp run

azure-pipelines · 2026-01-07T12:07:29Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-01-07T12:11:33Z

/azp run

azure-pipelines · 2026-01-07T12:11:43Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-01-07T12:12:55Z

/azp run

azure-pipelines · 2026-01-07T12:13:07Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-01-07T12:31:21Z

/azp run

azure-pipelines · 2026-01-07T12:31:31Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-01-07T12:48:08Z

/azp run

azure-pipelines · 2026-01-07T12:48:18Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-01-07T14:33:33Z

/azp run

azure-pipelines · 2026-01-07T14:33:44Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-01-07T15:20:08Z

/azp run

azure-pipelines · 2026-01-07T15:20:18Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-01-07T15:23:41Z

/azp run

azure-pipelines · 2026-01-07T15:23:53Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-01-12T14:55:08Z

/azp run

azure-pipelines · 2026-01-12T14:55:19Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-01-12T17:45:01Z

/azp run

azure-pipelines · 2026-01-12T17:45:12Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-01-12T18:24:29Z

/azp run

azure-pipelines · 2026-01-12T18:24:39Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-01-12T18:41:16Z

/azp run

azure-pipelines · 2026-01-12T18:41:27Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Yair Raviv <[email protected]>

mssonicbld · 2026-01-12T20:17:31Z

/azp run

azure-pipelines · 2026-01-12T20:17:43Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull request overview

This PR implements CLI commands for the Fast Link-Up feature, adding configuration and show commands for global settings and per-interface control. The implementation follows the SONiC CLI patterns for adding new feature commands, but contains critical bugs that prevent the interface command from working correctly.

Changes:

Added config switch-fast-linkup global to configure polling time, guard time, and BER threshold
Added config interface fast-linkup <interface> <mode> to enable/disable fast-linkup per port
Added show switch-fast-linkup global to display global configuration with table and JSON output
Added show interfaces fast-linkup status to display per-interface fast-linkup status
Extended portconfig script to support -fl flag for setting fast-linkup mode
Added comprehensive test suite with 15 test cases covering various scenarios
Updated Command Reference documentation with usage examples

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
tests/fast_linkup_test.py	Comprehensive test suite covering config/show commands, validation, and error cases
tests/fast_linkup_input/mock_state/supported/state_db.json	Mock STATE_DB data for supported platform scenario
tests/fast_linkup_input/mock_state/not_supported/state_db.json	Mock STATE_DB data for unsupported platform scenario
tests/fast_linkup_input/mock_config/ports/config_db.json	Mock CONFIG_DB data for port configuration tests
tests/fast_linkup_input/mock_config/global/config_db.json	Mock CONFIG_DB data for global configuration tests
show/main.py	Added `switch-fast-linkup global` command group with table/JSON output
show/interfaces/init.py	Added `fast-linkup status` subcommand to display per-interface status
scripts/portconfig	Extended portconfig with `-fl` flag to set fast-linkup mode via CONFIG_DB
doc/Command-Reference.md	Comprehensive documentation for all new commands with usage examples
config/main.py	Added `switch-fast-linkup global` and `interface fast-linkup` commands with validation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

config/main.py

doc/Command-Reference.md

show/main.py

mssonicbld · 2026-01-27T20:31:12Z

/azp run

azure-pipelines · 2026-01-27T20:31:23Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Yair Raviv <[email protected]>

mssonicbld · 2026-01-27T20:33:11Z

/azp run

azure-pipelines · 2026-01-27T20:33:22Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Yair Raviv <[email protected]>

mssonicbld · 2026-01-27T20:35:17Z

/azp run

azure-pipelines · 2026-01-27T20:35:28Z

Azure Pipelines successfully started running 1 pipeline(s).

YairRaviv · 2026-01-28T06:13:17Z

@qiluo-msft - Resolved all comments

YairRaviv mentioned this pull request Jan 7, 2026

Added Fast-linkup HLD sonic-net/SONiC#2170

Open

YairRaviv force-pushed the yraviv-fast-linkup-sonic-utilities branch from ba03a54 to 2881c71 Compare January 7, 2026 12:04

YairRaviv force-pushed the yraviv-fast-linkup-sonic-utilities branch from 2881c71 to 00800c5 Compare January 7, 2026 12:07

YairRaviv force-pushed the yraviv-fast-linkup-sonic-utilities branch from 00800c5 to 6bec417 Compare January 7, 2026 12:11

YairRaviv force-pushed the yraviv-fast-linkup-sonic-utilities branch from 6bec417 to 3524454 Compare January 7, 2026 12:12

YairRaviv force-pushed the yraviv-fast-linkup-sonic-utilities branch from 3524454 to 9df5b8a Compare January 7, 2026 12:31

YairRaviv force-pushed the yraviv-fast-linkup-sonic-utilities branch from 9df5b8a to ab914aa Compare January 7, 2026 12:48

YairRaviv force-pushed the yraviv-fast-linkup-sonic-utilities branch from ab914aa to 9b7b3d6 Compare January 7, 2026 14:33

YairRaviv force-pushed the yraviv-fast-linkup-sonic-utilities branch from 9b7b3d6 to 620bf18 Compare January 7, 2026 15:20

YairRaviv force-pushed the yraviv-fast-linkup-sonic-utilities branch from 620bf18 to 1a76a73 Compare January 7, 2026 15:23

YairRaviv force-pushed the yraviv-fast-linkup-sonic-utilities branch from 3089510 to d0c8056 Compare January 12, 2026 17:44

YairRaviv force-pushed the yraviv-fast-linkup-sonic-utilities branch from d0c8056 to c67b8f9 Compare January 12, 2026 18:24

YairRaviv force-pushed the yraviv-fast-linkup-sonic-utilities branch from c67b8f9 to 5183942 Compare January 12, 2026 18:41

[Fast-linkup] Added CLIs for config/show

e4a7798

Signed-off-by: Yair Raviv <[email protected]>

YairRaviv force-pushed the yraviv-fast-linkup-sonic-utilities branch from 5183942 to e4a7798 Compare January 12, 2026 20:17

YairRaviv marked this pull request as ready for review January 13, 2026 16:25

volodymyrsamotiy added the Request for 202511 Branch label Jan 14, 2026

qiluo-msft requested a review from Copilot January 27, 2026 19:23

Copilot started reviewing on behalf of qiluo-msft January 27, 2026 19:23 View session

Copilot AI reviewed Jan 27, 2026

View reviewed changes

config/main.py Show resolved Hide resolved

config/main.py Show resolved Hide resolved

config/main.py Outdated Show resolved Hide resolved

doc/Command-Reference.md Show resolved Hide resolved

show/main.py Outdated Show resolved Hide resolved

Fast-linkup | Removed multiple enablement options

8a5474a

Signed-off-by: Yair Raviv <[email protected]>

YairRaviv force-pushed the yraviv-fast-linkup-sonic-utilities branch from bdd69f7 to 8a5474a Compare January 27, 2026 20:31

Fast-linkup | Added missing ranges test

696c7e6

Signed-off-by: Yair Raviv <[email protected]>

[Fast-linkup] Added CLIs for config/show #4182

Are you sure you want to change the base?

[Fast-linkup] Added CLIs for config/show #4182

Uh oh!

Conversation

YairRaviv commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What I did

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

New command output (if the output of a command-line utility has changed)

Uh oh!

mssonicbld commented Jan 7, 2026

Uh oh!

azure-pipelines bot commented Jan 7, 2026

Uh oh!

mssonicbld commented Jan 7, 2026

Uh oh!

azure-pipelines bot commented Jan 7, 2026

Uh oh!

mssonicbld commented Jan 7, 2026

Uh oh!

azure-pipelines bot commented Jan 7, 2026

Uh oh!

mssonicbld commented Jan 7, 2026

Uh oh!

azure-pipelines bot commented Jan 7, 2026

Uh oh!

mssonicbld commented Jan 7, 2026

Uh oh!

azure-pipelines bot commented Jan 7, 2026

Uh oh!

mssonicbld commented Jan 7, 2026

Uh oh!

azure-pipelines bot commented Jan 7, 2026

Uh oh!

mssonicbld commented Jan 7, 2026

Uh oh!

azure-pipelines bot commented Jan 7, 2026

Uh oh!

mssonicbld commented Jan 7, 2026

Uh oh!

azure-pipelines bot commented Jan 7, 2026

Uh oh!

mssonicbld commented Jan 7, 2026

Uh oh!

azure-pipelines bot commented Jan 7, 2026

Uh oh!

mssonicbld commented Jan 7, 2026

Uh oh!

azure-pipelines bot commented Jan 7, 2026

Uh oh!

mssonicbld commented Jan 12, 2026

Uh oh!

azure-pipelines bot commented Jan 12, 2026

Uh oh!

mssonicbld commented Jan 12, 2026

Uh oh!

azure-pipelines bot commented Jan 12, 2026

Uh oh!

mssonicbld commented Jan 12, 2026

Uh oh!

azure-pipelines bot commented Jan 12, 2026

Uh oh!

mssonicbld commented Jan 12, 2026

Uh oh!

azure-pipelines bot commented Jan 12, 2026

Uh oh!

mssonicbld commented Jan 12, 2026

Uh oh!

azure-pipelines bot commented Jan 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

YairRaviv commented Jan 7, 2026 •

edited

Loading