-
Notifications
You must be signed in to change notification settings - Fork 13
Add support for multiple controllers (UI still pending). #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
||
| void zelda64::reset_cont_input_bindings() { | ||
| assign_all_mappings(recomp::InputDevice::Controller, recomp::default_n64_controller_mappings); | ||
| // TODO: Needs the active controller tab. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this comment.
hhirsch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. LGTM
|
Hi Dario and hhirsch, Is this in the current release build already? If so, can you provide an example config.json with the config version that supports controller indexes? I don't really care if there's a UI and just prefer to manually edit the config files so we can use it now for couch multiplayer. Thanks! |
Hey, The approach in this PR is being deprecated in favor of a new redesign coming in general to all recomps that will allow local multiplayer configuration. The formats for configuration in that redesign are very different from the ones supported in this PR, so merging this would cause trouble for keeping the controller configuration backwards compatible. Best I can recommend is to just wait for that redesign to be ready. I'm sure this Recomp will get it as soon as it's ready. |
|
Is it possible to add support for the Wii U GameCube controller adaptor? |
This is a pull request for a specific feature. Asking the author to implement random new features is not constructive. Open a new issue for your feature request. |
Is there somewhere that progress on that can be followed? If so, could you provide a link to it? I haven't been able to find anything about that redesign in the N64Recomp repo. |
I can't really promise any specific timeline, but the redesign is very close to being done. |
|
I understand. I was just wondering if there was a PR somewhere which I could follow. Thank you. |
|
Even though this isn't finished, can we get a working build for windows and/or linux? I've tried for hours to get a build to compile but even using vs2022 and following BUILDING.md I cannot build on Windows or Ubuntu. I'd suggest mirroring the controller scheme for the first controller per the UI that's already implemented...for the other controllers. |
@DarioSamo Close this PR then. |

TODO
controls.json.