Skip to content

Conversation

@zzy-33
Copy link
Contributor

@zzy-33 zzy-33 commented Aug 14, 2025

  1. update website readme.md
  2. update taro4.x use tailwindcss import
  3. add use with taroify

Sourcery 总结

更新网站文档,新增项目设置说明,改进 Taro v3 和 v4 集成指南,并在导航中添加了新的“与 taroify 一起使用”指南。

文档变更:

  • 在网站 README 中添加项目启动和错误解决步骤
  • 澄清 Taro 集成,将 Taro 部分重命名为 v3,并为 Taro 4.x 添加 TailwindCSS @use 示例
  • 引入“与 taroify 一起使用”指南,并将其注册到侧边栏
Original summary in English

Summary by Sourcery

Update website documentation with project setup instructions, improved Taro integration guidance for v3 and v4, and a new ‘use with taroify’ guide added to navigation

Documentation:

  • Add project startup and error resolution steps to website README
  • Clarify Taro integration by renaming Taro section to v3 and adding TailwindCSS @use example for Taro 4.x
  • Introduce a ‘use with taroify’ guide and register it in the sidebar

@changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2025

⚠️ No Changeset found

Latest commit: fb38b00

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Aug 14, 2025

Deploy Preview for ice-tw canceled.

Name Link
🔨 Latest commit fb38b00
🔍 Latest deploy log https://app.netlify.com/projects/ice-tw/deploys/689dee3139f79a0008d4fc07

@sourcery-ai
Copy link

sourcery-ai bot commented Aug 14, 2025

审阅者指南

此拉取请求通过添加项目启动和错误解决说明,澄清 Taro 3.x 与 4.x 的 Tailwind 用法,并引入新的“与 Taroify 一起使用”指南(包含 babel-plugin-import 的配置步骤和导入顺序调整),增强了网站文档。

Taroify 集成中 Babel 插件配置的类图

classDiagram
    class BabelConfig {
      +plugins: Array
    }
    class ImportPlugin {
      +libraryName: string
      +libraryDirectory: string
      +style: boolean
      +customName: function
    }
    BabelConfig --> ImportPlugin : uses
    ImportPlugin <|-- TaroifyCoreImport
    ImportPlugin <|-- TaroifyIconsImport
    class TaroifyCoreImport {
      +libraryName = "@taroify/core"
      +libraryDirectory = ""
      +style = false
    }
    class TaroifyIconsImport {
      +libraryName = "@taroify/icons"
      +libraryDirectory = ""
      +camel2DashComponentName = false
      +style = false
      +customName: function
    }
Loading

文件级变更

变更 详情 文件
为 README 补充项目启动和构建故障排除说明
  • 在“启动项目”部分下添加了 pnpm install 和 dev 命令
  • 包含了通过在本地运行 pnpm build 解决“Module not found”错误的步骤
website/README.md
扩展快速入门指南以区分 Taro 3.x 和 Taro 4.x 的 Tailwind 设置
  • 将现有 Taro 部分重命名为“Taro 3.x”
  • 引入了新的“Taro 4.x”部分,其中包含 Sass 环境说明和 @use 指令
website/docs/quick-start/install.mdx
引入“与 Taroify 一起使用”文档和侧边栏条目
  • 为 use-with-taroify 添加了侧边栏链接
  • 创建了一个新的 Markdown 文档,概述了 babel-plugin-import 配置以禁用默认样式
  • 记录了 Taroify 和 Tailwind CSS 在 app.tsx 和 app.scss 中的正确导入顺序
website/sidebars.ts
website/docs/issues/use-with-taroify.md

提示和命令

与 Sourcery 互动

  • 触发新审阅: 在拉取请求上评论 @sourcery-ai review
  • 继续讨论: 直接回复 Sourcery 的审阅评论。
  • 从审阅评论生成 GitHub Issue: 通过回复审阅评论,要求 Sourcery 从中创建一个 issue。您也可以回复审阅评论并添加 @sourcery-ai issue 来创建 issue。
  • 生成拉取请求标题: 在拉取请求标题的任意位置写入 @sourcery-ai 即可随时生成标题。您也可以在拉取请求上评论 @sourcery-ai title 来随时(重新)生成标题。
  • 生成拉取请求摘要: 在拉取请求正文的任意位置写入 @sourcery-ai summary 即可随时在您想要的位置生成 PR 摘要。您也可以在拉取请求上评论 @sourcery-ai summary 来随时(重新)生成摘要。
  • 生成审阅者指南: 在拉取请求上评论 @sourcery-ai guide 即可随时(重新)生成审阅者指南。
  • 解决所有 Sourcery 评论: 在拉取请求上评论 @sourcery-ai resolve 以解决所有 Sourcery 评论。如果您已处理完所有评论并且不想再看到它们,这会很有用。
  • 驳回所有 Sourcery 审阅: 在拉取请求上评论 @sourcery-ai dismiss 以驳回所有现有的 Sourcery 审阅。如果您想从新的审阅开始,这会特别有用——别忘了评论 @sourcery-ai review 来触发新的审阅!

自定义您的体验

访问您的仪表盘以:

  • 启用或禁用审阅功能,例如 Sourcery 生成的拉取请求摘要、审阅者指南等。
  • 更改审阅语言。
  • 添加、删除或编辑自定义审阅说明。
  • 调整其他审阅设置。

获取帮助

Original review guide in English

Reviewer's Guide

This PR enhances the website documentation by adding project startup and error-resolution instructions, clarifies Tailwind usage for Taro 3.x vs 4.x, and introduces a new “use with Taroify” guide with configuration steps for babel-plugin-import and import order adjustments.

Class diagram for Babel plugin configuration for Taroify integration

classDiagram
    class BabelConfig {
      +plugins: Array
    }
    class ImportPlugin {
      +libraryName: string
      +libraryDirectory: string
      +style: boolean
      +customName: function
    }
    BabelConfig --> ImportPlugin : uses
    ImportPlugin <|-- TaroifyCoreImport
    ImportPlugin <|-- TaroifyIconsImport
    class TaroifyCoreImport {
      +libraryName = "@taroify/core"
      +libraryDirectory = ""
      +style = false
    }
    class TaroifyIconsImport {
      +libraryName = "@taroify/icons"
      +libraryDirectory = ""
      +camel2DashComponentName = false
      +style = false
      +customName: function
    }
Loading

File-Level Changes

Change Details Files
Augment README with project startup and build troubleshooting instructions
  • Added pnpm install and dev commands under a “启动项目” section
  • Included steps to resolve Module not found errors by running pnpm build locally
website/README.md
Extend quick-start guide to distinguish Taro 3.x and Taro 4.x Tailwind setup
  • Renamed the existing Taro section to “Taro 3.x”
  • Introduced a new “Taro 4.x” section with Sass environment notes and @use directives
website/docs/quick-start/install.mdx
Introduce “use with Taroify” documentation and sidebar entry
  • Added a sidebar link for use-with-taroify
  • Created a new markdown doc outlining babel-plugin-import config to disable default styles
  • Documented proper import order of Taroify and Tailwind CSS in app.tsx and app.scss
website/sidebars.ts
website/docs/issues/use-with-taroify.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你好 - 我已经审查了你的修改,它们看起来很棒!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
请帮助我更有用!请在每条评论上点击 👍 或 👎,我将使用反馈来改进你的评论。
Original comment in English

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.38%. Comparing base (6576117) to head (fb38b00).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #684      +/-   ##
==========================================
+ Coverage   90.26%   90.38%   +0.11%     
==========================================
  Files          71       75       +4     
  Lines        5630     5700      +70     
  Branches      653      671      +18     
==========================================
+ Hits         5082     5152      +70     
  Misses        548      548              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.


### Taro
### Taro 3.x

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其实用不着分 Taro3.x 和 Taro4.x,因为这个警告报错只和 Sass 的版本有关,我的想法是在代码块里面,把这几个写法都写上。

```scss
// src/app.scss

@use 'tailwindcss/base' as *;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as * 应该不用加

@sonofmagic sonofmagic self-assigned this Aug 14, 2025
@sonofmagic
Copy link
Owner

@zzy-33 https://sass-lang.com/documentation/at-rules/import/
As of Dart Sass 1.80.0, the @import rule is deprecated and will be removed from the language in Dart Sass 3.0.0. Prefer the @use rule instead.

所以是 sass 版本问题

@zzy-33 zzy-33 requested a review from sonofmagic August 14, 2025 11:42

修改根目录下的样式引入顺序,优先引入[Taroify](https://taroify.github.io/taroify.com/) 的样式,再引入Tailwindcss的样式

```tsc
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tsc 是 ts 编译器,你要的是 ts 或者 tsx 吧?

@sonarqubecloud
Copy link

@sonofmagic sonofmagic merged commit 61630f4 into sonofmagic:main Aug 14, 2025
11 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants