Skip to content

Conversation

@vicalca
Copy link

@vicalca vicalca commented Sep 18, 2025

Description

Bumps fastmcp to version 2.5.0, which by default now returns error messages to the LLM.
This is very useful since it allows LLMs to self-correct once the error message is received, making this MCP server much more useful and reliable.

Fixes: #690 #670

Changes

  • Bumps fastmcp to >= 2.5.0

Testing

  • Unit tests added/updated
  • Integration tests passed
  • Manual checks performed: npx @modelcontextprotocol/inspector uv --directory /path/to/local/installation run mcp-atlassian

Checklist

  • Code follows project style guidelines (linting passes).
  • Tests added/updated for changes.
  • All tests pass locally.
  • Documentation updated (if needed).

Bumps fastmcp to >= 2.5.0, < 2.6.0
@vicalca vicalca force-pushed the feature/informative-error-messages branch 2 times, most recently from 6297916 to ffff890 Compare September 25, 2025 07:44
@vicalca vicalca force-pushed the feature/informative-error-messages branch from ffff890 to 79cf28a Compare September 25, 2025 07:45
@vicalca vicalca marked this pull request as ready for review September 25, 2025 07:47
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity for 14 days. It will be closed if no further activity occurs. Please leave a comment or remove the 'stale' label if you believe this PR is still relevant. Thank you for your contributions!

@github-actions github-actions bot added the stale label Oct 10, 2025
nszceta added a commit to nszceta/mcp-atlassian that referenced this pull request Oct 16, 2025
@NicolaeNMV
Copy link

NicolaeNMV commented Dec 1, 2025

I've now encountered an error which claude couldn't auto correct because it couldn't see the errors coming from jira.

My understanding is that this change could help with this.

Here is my full stack trace which I got when I activated all debugging flags. cc @sooperset

ERROR - mcp-jira - Error creating Sub-task: expected 'key' property to be a string
[12/01/25 11:18:57] ERROR    Error calling tool              tool_manager.py:129
                             'create_issue': expected 'key'
                             property to be a string
                             ╭─ Traceback (most recent cal─╮
                             │ /app/.venv/lib/python3.10/s │
                             │ ite-packages/fastmcp/tools/ │
                             │ tool_manager.py:120 in      │
                             │ call_tool                   │
                             │                             │
                             │   117 │   │   │   raise Not │
                             │   118 │   │                 │
                             │   119 │   │   try:          │
                             │ ❱ 120 │   │   │   return aw │
                             │   121 │   │                 │
                             │   122 │   │   # raise ToolE │
                             │   123 │   │   except ToolEr │
                             │                             │

...
                             │ /app/.venv/lib/python3.10/s │
                             │ ite-packages/atlassian/rest │
                             │ _client.py:994 in           │
                             │ raise_for_status            │
                             │                             │
                             │    991 │   │   │   │   log. │
                             │    992 │   │   │   │   resp │
                             │    993 │   │   │   else:    │
                             │ ❱  994 │   │   │   │   rais │
                             │    995 │   │   else:        │
                             │    996 │   │   │   response │
                             │    997                      │
                             ╰─────────────────────────────╯
                             HTTPError: expected 'key'

ERROR - FastMCP.fastmcp.tools.tool_manager - Error calling tool 'create_issue': expected 'key' property to be a string
Traceback (most recent call last):
  File "/app/.venv/lib/python3.10/site-packages/fastmcp/tools/tool_manager.py", line 120, in call_tool
    return await tool.run(arguments)
  File "/app/.venv/lib/python3.10/site-packages/fastmcp/tools/tool.py", line 144, in run
    result = await result
  File "/app/.venv/lib/python3.10/site-packages/mcp_atlassian/utils/decorators.py", line 42, in wrapper
    return await func(ctx, *args, **kwargs)
  File "/app/.venv/lib/python3.10/site-packages/mcp_atlassian/servers/jira.py", line 698, in create_issue
    issue = jira.create_issue(
  File "/app/.venv/lib/python3.10/site-packages/mcp_atlassian/jira/issues.py", line 612, in create_issue
    response = self.jira.create_issue(fields=fields)
  File "/app/.venv/lib/python3.10/site-packages/atlassian/jira.py", line 1729, in create_issue
    return self.post(url, params=params, data=data)
  File "/app/.venv/lib/python3.10/site-packages/atlassian/rest_client.py", line 713, in post
    response = self.request(
  File "/app/.venv/lib/python3.10/site-packages/atlassian/rest_client.py", line 445, in request
    self.raise_for_status(response)
  File "/app/.venv/lib/python3.10/site-packages/atlassian/rest_client.py", line 994, in raise_for_status
    raise HTTPError(error_msg, response=response)
requests.exceptions.HTTPError: expected 'key' property to be a string

After claude could find this error from the docker logs, it could correct itself.

@github-actions github-actions bot removed the stale label Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants