fix(oauth_setup): sanitize user input for interactive prompts #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `_sanitize_input` to trim leading/trailing whitespace and remove Windows/Unix/Mac line endings. * Use `_sanitize_input` in `_prompt_for_input` for both env-default and manual input branches. * Prevents accidental CRLFs or trailing/leading whitespace from corrupting values (redirect URIs, client IDs, secrets) during the OAuth setup wizard.
…trailing whitespace
* Replace single quotes with double quotes in `rstrip("\r\n")` for consistent quoting style.
* Add minor formatting cleanup (extra blank line) for readability.
* No functional changes.
nszceta
added a commit
to nszceta/mcp-atlassian
that referenced
this pull request
Oct 16, 2025
…eractive prompts
|
This pull request has been automatically marked as stale because it has not had recent activity for 14 days. It will be closed if no further activity occurs. Please leave a comment or remove the 'stale' label if you believe this PR is still relevant. Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
_sanitize_inputto trim leading/trailing whitespace and remove Windows/Unix/Mac line endings._sanitize_inputin_prompt_for_inputfor both env-default and manual input branches.I faced an issue while using oauth config script on windows machine, where it kept adding \r\n as part of parameters passed from console. this
Fixes: #
Changes
Testing
[briefly describe]Checklist