Skip to content

Fix regressions from syslog per-region enhancement #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mamullen13316 merged 6 commits into from
Nov 14, 2025
Merged

Fix regressions from syslog per-region enhancement #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e67fc7f
add per-region support for syslog servers
mamullen13316 Nov 14, 2025
55a556e
update version to v1.0.18
mamullen13316 Nov 14, 2025
ed56909
fix issue when syslog server in expected is not configured on actual
mamullen13316 Nov 14, 2025
7da82a3
update version to v1.0.19
mamullen13316 Nov 14, 2025
443e46c
re-enable all rules
mamullen13316 Nov 14, 2025
4c17736
Merge branch 'main' into syslog_regional
mamullen13316 Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "sophos-firewall-audit"
version = "1.0.18"
version = "1.0.19"
description = "Sophos Firewall Audit"
authors = ["Matt Mullen <matt.mullen@sophos.com>"]
readme = "README.md"
Expand Down
2 changes: 1 addition & 1 deletion sophos_firewall_audit/rules/syslog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def eval_syslog(fw_obj: SophosFirewall,
settings_dict[key] = {}
settings_dict[key]["Name"] = container_name
settings_dict[key]["Expected"] = settings_container[key]
if key == "Format":
if key == "Format" and container_name in actual_settings:
if actual_settings[container_name][key] == "3":
actual_settings[container_name][key] = "Standard syslog"
settings_dict[key]["Actual"] = actual_settings[container_name][key] if container_name in actual_settings else f"{container_name} not configured!"
Expand Down